Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java workflow quickstart #922

Closed
wants to merge 2 commits into from

Conversation

skyao
Copy link
Member

@skyao skyao commented Sep 20, 2023

Description

Add Java workflow quickstart

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #903

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
…update readme

Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Copy link
Contributor

@mukundansundar mukundansundar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skyao Overall the code looks good, please fix the validation failure that is happening for workflow java validation

workflows/java/sdk/order-processor/pom.xml Show resolved Hide resolved
@msfussell msfussell added this to the 1.12 milestone Sep 20, 2023
@mukundansundar mukundansundar removed this from the 1.12 milestone Sep 20, 2023
@msfussell
Copy link
Member

@skyao - There is now a branch for release-1.12 in this repo. Can you target this PR into this branch, which means that we can test this with going into main

@skyao
Copy link
Member Author

skyao commented Sep 22, 2023

@mukundansundar This PR failed because of new version of dapr-sdk-workflows is not released to maven central repo. 0.10.0-SNAPSHOT is a develop version. So, what can I do at this time? Should we need to wait for the new release of dapr java sdk before we merge this PR?

[Warning: G] The POM for io.dapr:dapr-sdk-workflows:jar:0.10.0-SNAPSHOT is missing, no dependency information available

@skyao skyao mentioned this pull request Sep 22, 2023
4 tasks
@skyao
Copy link
Member Author

skyao commented Sep 22, 2023

Replaced by PR #925 to target to release-1.12 branch.

@skyao skyao closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow Java SDK Code Sample
3 participants