Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go validation workflow to 1.21 #986

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented Feb 13, 2024

Description

Bumps the go validation workflow to 1.21 (and setup-go to v5 / checkout to v4).

Issue reference

Unreferenced

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
@mikeee
Copy link
Member Author

mikeee commented Feb 13, 2024

@paulyuk Could I please get your eyes on this PR with changes only related to go. Bumped the go version to match the runtime and sdk minimum supported version to unblock the workflow quickstart.

Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. if you can please make all 1.13 endgame changes in 1.13 branch however. For this I'll port.

@paulyuk paulyuk merged commit ec1e515 into dapr:master Feb 14, 2024
5 of 7 checks passed
@mikeee mikeee mentioned this pull request Feb 14, 2024
4 tasks
mikeee pushed a commit to mikeee/dapr_quickstarts that referenced this pull request Feb 14, 2024
bump go validation workflow to 1.21

(cherry picked from commit ec1e515)
mikeee pushed a commit to mikeee/dapr_quickstarts that referenced this pull request Feb 14, 2024
bump go validation workflow to 1.21

(cherry picked from commit ec1e515)
Signed-off-by: mikeee <hey@mike.ee>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants