Overhaul development and test dependencies. #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to simplify and update the dependencies for this project. There are a few reasons for this: - The GitHub workflow for testing that would run on each push was failing because the dependencies were out of date. - The JavaScript testing framework 'nodeunit' has not been under active development for a long time and has numerous security vulnerabilities. - The development tooling workflow library Grunt has not been under active development for some time and has numerous security vulnerabilities. It is also unnecessary, as the functionality can be replicated with using `npm` scripts defined in `package.json`. What was done: - Removed Grunt. Replaced it with NPM scripts in `package.json`. - Removed nodeunit. Replaced it with the Jest JavaScript testing framework and updated the tests accordingly. - Removed jsonlint. Replaced it with @prantlf/jsonlint, a fork that is actively maintained. - Updated JSHint. - Updated README to replace mention of Grunt with an example of how to run Javascript tests. - Update GitHub Actions workflow YAML to reflect new JS testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to simplify and update the dependencies for this project.
There are a few reasons for this:
package.json.What was done:
package.json.I have a few other PRs in the hopper for this project, but I wanted to get the baseline dependencies updated and automated tests working before going any further.