From f4e6d1d250ae8f8e5fc521c5d90b7a579aa4c455 Mon Sep 17 00:00:00 2001 From: "pawel.urban" Date: Tue, 21 Nov 2017 08:53:46 +0100 Subject: [PATCH 1/3] Fixed a misspelling in an exception print out. --- .../rxandroidble/internal/serialization/QueueSemaphore.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rxandroidble/src/main/java/com/polidea/rxandroidble/internal/serialization/QueueSemaphore.java b/rxandroidble/src/main/java/com/polidea/rxandroidble/internal/serialization/QueueSemaphore.java index dc60b1d73..41d996f58 100644 --- a/rxandroidble/src/main/java/com/polidea/rxandroidble/internal/serialization/QueueSemaphore.java +++ b/rxandroidble/src/main/java/com/polidea/rxandroidble/internal/serialization/QueueSemaphore.java @@ -16,7 +16,7 @@ public synchronized void awaitRelease() throws InterruptedException { } catch (InterruptedException e) { if (!isReleased.get()) { RxBleLog.w(e, "Queue's awaitRelease() has been interrupted abruptly " - + "while it wasn't released byte release() method."); + + "while it wasn't released by the release() method."); } } } From 0819183381f1a2f2ebf1dd37aa46d748a0a87810 Mon Sep 17 00:00:00 2001 From: "pawel.urban" Date: Tue, 21 Nov 2017 13:15:06 +0100 Subject: [PATCH 2/3] [#309] Migrated to Groovy plugin 2.0.0 which is fixing issues with Gradle 3.0.0 and the newest Android plugin. --- build.gradle | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/build.gradle b/build.gradle index 5d78e4de4..5fa1ba06f 100644 --- a/build.gradle +++ b/build.gradle @@ -9,8 +9,8 @@ buildscript { dependencies { classpath 'com.android.tools.build:gradle:3.0.0' - classpath 'com.github.ben-manes:gradle-versions-plugin:0.14.0' - classpath 'org.codehaus.groovy:groovy-android-gradle-plugin:1.2.0' + classpath 'com.github.ben-manes:gradle-versions-plugin:0.15.0' + classpath 'org.codehaus.groovy:groovy-android-gradle-plugin:2.0.0' } } From 47de66269f4a4f1cd710ec80dd389339021249bf Mon Sep 17 00:00:00 2001 From: "pawel.urban" Date: Tue, 21 Nov 2017 13:46:37 +0100 Subject: [PATCH 3/3] [#309] Removed a workaround that created apt directories in tests. Groovy plugin will handle it itself when skipJavaC is applied. --- rxandroidble/build.gradle | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/rxandroidble/build.gradle b/rxandroidble/build.gradle index ec40fe418..0e4980474 100644 --- a/rxandroidble/build.gradle +++ b/rxandroidble/build.gradle @@ -42,18 +42,8 @@ android { preBuild.dependsOn 'checkstyle' } -// Workaround until groovy-android-gradle-plugin 1.3.0 is released -tasks.whenTaskAdded { task -> - if (task.name.contains('UnitTestGroovyWithGroovyc')) { - task.doFirst { - ['debug','release'].each { - def dir = file("build/generated/source/apt/test/$it") - if(!dir.isDirectory()){ - dir.mkdirs() - } - } - } - } +androidGroovy { + skipJavaC = true } dependencies {