feat: Manage executable path in darlingserver #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facekapow
requested changes
Apr 5, 2022
|
Like I said in the darlingserver PR, there are things you wouldn't know to do because I simply haven't documented them (e.g. the meaning of negative error codes from RPC calls). |
|
Fixed. |
facekapow
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With darlingserver managing executable paths,
_proc_pidinfo_pathinfocan get the path from darlingserver instead of procfs (which points to mldr instead of the real path).Also,
mldrnow announces the executable path after loading and before starting the thread.