This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Make StreamQueue start listening immediately to broadcast streams. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a `StreamQueue` is created for a broadcast stream, it didn't use to listen to the stream immediately, which means that any events sent before the first call to `next` (or any other queue request) would be silently lost. That makes an initial `peek` operation change the behavior of the queue, which is confusing to users.
|
So far I've only found one use case that this breaks (a test was mocking a I think this is the right thing to do. I do wonder whether we should roll this out before or after NNBD and whether we should model it as a breaking change. My gut reaction is to treat this as non-breaking and try to get it out ASAP. @jakemac53 - do you have any thoughts? I'll try to run more tests and see if anything more scare comes up. |
|
Ya, I would say run it through an internal presubmit and as long as that seems reasonable to land then |
natebosch
approved these changes
Jun 30, 2020
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 14, 2024
…art-archive/async#119) When a `StreamQueue` is created for a broadcast stream, it didn't use to listen to the stream immediately, which means that any events sent before the first call to `next` (or any other queue request) would be silently lost. That makes an initial `peek` operation change the behavior of the queue, which is confusing to users.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
StreamQueueis created for a broadcast stream, it didn't use to listen to the stream immediately, which means that any events sent before the first call tonext(or any other queue request) would be silently lost. That makes an initialpeekoperation change the behavior of the queue, which is confusing to users.