Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Prepare to publish stable null safety #153

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Prepare to publish stable null safety #153

merged 2 commits into from
Feb 2, 2021

Conversation

natebosch
Copy link
Contributor

Bump to stable version of collection.

@natebosch
Prepare to publish stable null safety
b6815c1 
Bump to stable version of `collection`.
@natebosch natebosch requested a review from jakemac53 January 29, 2021 18:43
@google-cla google-cla bot added the cla: yes label Jan 29, 2021
@natebosch
Copy link
Contributor Author

There is a small diff in lib/ for this package. We retained the addition of a library directive and a doc comment.

2.5.0-nullsafety.3...e4d75c1

This mainly has an impact on DartDoc. I confirmed that dartdoc on the latest dev Dart SDK renders this as we hope.

Before:

image

After:

image

@natebosch
Copy link
Contributor Author

We expect CI to fail due to issues with dependency cycles in dev_dependencies that will not impact the publish.

@natebosch natebosch merged commit 376d418 into master Feb 2, 2021
@natebosch natebosch deleted the publish branch February 2, 2021 19:16
mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 14, 2024
@natebosch
Prepare to publish stable null safety (dart-archive/async#153)
9dde9dc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakemac53 jakemac53 jakemac53 approved these changes

Assignees
No one assigned
Labels
cla: yes
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natebosch @jakemac53