This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Style tweaks in stream_queue.dart #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use a noun phrase to document the `hasNext` getter. The `next` and `peek` getters keep their verb phrase doc comments since the side effects are critical distinctions between these methods. If we were writing this today, `next()` would be a method. - Change `_failClosed()` which returns an error, to `_checkClosed()` which checks the condition and optionally closes. Avoid nesting the majority of method behavior in a conditional. - Use `RangeError.checkNotNegative` over a conditional. - Change bare `Future` to `Future<void>` in code examples. - Make `withTransaction` `async` since there is no longer a blocker now that async methods start running synchronously.
jakemac53
reviewed
Apr 21, 2021
jakemac53
approved these changes
Apr 21, 2021
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 14, 2024
- Use a noun phrase to document the `hasNext` getter. The `next` and `peek` getters keep their verb phrase doc comments since the side effects are critical distinctions between these methods. If we were writing this today, `next()` would be a method. - Change `_failClosed()` which returns an error, to `_checkNotClosed()` which checks the condition and optionally closes. Avoid nesting the majority of method behavior in a conditional. - Use `RangeError.checkNotNegative` over a conditional. - Change bare `Future` to `Future<void>` in code examples. - Make `withTransaction` `async` since there is no longer a blocker now that async methods start running synchronously.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasNextgetter. Thenextandpeekgetters keep their verb phrase doc comments since the sideeffects are critical distinctions between these methods. If we were
writing this today,
next()would be a method._failClosed()which returns an error, to_checkClosed()which checks the condition and optionally closes. Avoid nesting the
majority of method behavior in a conditional.
RangeError.checkNotNegativeover a conditional.FuturetoFuture<void>in code examples.withTransactionasyncsince there is no longer a blocker nowthat async methods start running synchronously.