This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Fix broadcast StreamGroup ignores streams added after StreamGroup is canceled #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
Great find and fix, @anhtuan23 !! |
jakemac53
approved these changes
Jul 20, 2021
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 14, 2024
…-archive/async#184) In a broadcast `StreamGroup` when all listeners have canceled the inner subscriptions are kept only for single subscriber streams. When a new listener is added and subscriptions need to be recreated for inner broadcast streams the presence of a single subscriber subscription in the collection of subscriptions would cause the listen to bail out early and fail to subscribe to later broadcast streams. Change `return` to `continue` to keep going with the rest of the streams.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix dart-lang/core#344