This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Avoid copying with BytesBuilder #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation of `collectBytes` would return a `Uint8List` where the `lengthInBytes` and `buffer.lengthInBytes` matched. This property isn't an intended guarantee, however since some callers may rely on it for correct behavior it is safer to retain it. Use `toBytes` to create a copy with the correct length.
lrhn
reviewed
Jul 1, 2021
lib/src/byte_collector.dart
Outdated
| @@ -46,7 +46,7 @@ T _collectBytes<T>(Stream<List<int>> source, | |||
| var completer = Completer<Uint8List>.sync(); | |||
| var subscription = | |||
| source.listen(bytes.add, onError: completer.completeError, onDone: () { | |||
| completer.complete(bytes.takeBytes()); | |||
| completer.complete(bytes.toBytes()); | |||
There was a problem hiding this comment.
Try using a BytesBuilder(copy: false) instead, then use takeBytes.
There was a problem hiding this comment.
Using copy: false seems to fix it. I'll use that. Thanks!
lrhn
approved these changes
Jul 1, 2021
natebosch
changed the title
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 14, 2024
The previous implementation of `collectBytes` would return a `Uint8List` where the `lengthInBytes` and `buffer.lengthInBytes` matched. This property isn't an intended guarantee, however since some callers may rely on it for correct behavior it is safer to retain it. Use `copy: false` so that the buffer used in `takeBytes` has the same length as the data.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of
collectByteswould return aUint8Listwhere the
lengthInBytesandbuffer.lengthInBytesmatched. Thisproperty isn't an intended guarantee, however since some callers may
rely on it for correct behavior it is safer to retain it. Use
copy: falseso that the buffer used in
takeByteshas the same length as the data.