Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Prepare to publish (again) #190

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Prepare to publish (again) #190

merged 1 commit into from
Jul 22, 2021

Conversation

natebosch
Copy link
Contributor

I made the previous publish at a commit too early. Move the changelog
for the StreamGroup bug fix to a new version and prepare to publish.

I made the previous publish at a commit too early. Move the changelog
for the `StreamGroup` bug fix to a new version and prepare to publish.
@natebosch natebosch requested a review from kevmoo July 22, 2021 20:57
@google-cla google-cla bot added the cla: yes label Jul 22, 2021
Copy link
Contributor

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you documented a feature in 2.8.0 that WASN'T in that release? Just making sure I understand.

@natebosch
Copy link
Contributor Author

So you documented a feature in 2.8.0 that WASN'T in that release? Just making sure I understand.

No. 2.8.0 is a valid release with a coherent changelog. We weren't using the -dev strategy in this case so publishing from either 4a1e1d8 or 25a7e2e would be valid. I published from the earlier commit so neither the bug fix nor the changelog for the bug fix were present.

@natebosch natebosch merged commit f77b130 into master Jul 22, 2021
@natebosch natebosch deleted the publish-again branch July 22, 2021 21:12
mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 14, 2024
I made the previous publish at a commit too early. Move the changelog
for the `StreamGroup` bug fix to a new version and prepare to publish.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

2 participants