Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Stop depending on pkg:charcode and pkg:pedantic. #191

Merged
merged 7 commits into from
Aug 10, 2021
Merged

Stop depending on pkg:charcode and pkg:pedantic. #191

merged 7 commits into from
Aug 10, 2021

Conversation

lrhn
Copy link
Contributor

@lrhn lrhn commented Jul 26, 2021

Use pkg:lints instead of pkg:pedantic (and update code as necessary).
Use a local constant instead of depending on pkg:charcode.

@lrhn lrhn requested a review from natebosch July 26, 2021 09:29
@google-cla google-cla bot added the cla: yes label Jul 26, 2021
analysis_options.yaml Show resolved Hide resolved
@natebosch
Copy link
Contributor

The remaining failure should be resolved after the linter package is rolled into the SDK and we have another dev release.

dart-lang/sdk#58462

lrhn added 3 commits August 10, 2021 16:00
Use pkg:lints instead of pkg:pedantic (and update code as necessary).
Use a local constant instead of depending on pkg:charcode.
@lrhn lrhn merged commit 65b1d98 into master Aug 10, 2021
mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 14, 2024
)

Stop depending on pkg:charcode and pkg:pedantic.

Use pkg:lints instead of pkg:pedantic (and update code as necessary).
Use a local constant instead of depending on pkg:charcode.

Remove unnecessary clutter in analysis_options.yaml, but do retain 
 `analyzer`/`strong-mode`/`implicit-casts: false`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants