This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Two small strong-mode/warning fixes #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
reviewed
Jan 24, 2017
| @@ -101,5 +100,5 @@ class _TransformedSubscription<T> implements StreamSubscription<T> { | |||
| } | |||
|
|
|||
| Future/*<E>*/ asFuture/*<E>*/([/*=E*/ futureValue]) => | |||
| _inner?.asFuture(futureValue) ?? new Completer().future; | |||
| _inner?.asFuture(futureValue) ?? new Completer/*<E>*/().future; | |||
There was a problem hiding this comment.
@jmesserly Shouldn't this be inferred?
There was a problem hiding this comment.
Hmmm. Not sure, I know we have inference for ??. Do you know what the error message was?
There was a problem hiding this comment.
oooooooooh ... NVM, this is the bug: dart-lang/sdk#27114
There was a problem hiding this comment.
Unsafe implicit cast from 'Future<dynamic>' to 'Future<E>'.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing an unused import and fixing a dynamic inference.