Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Two small strong-mode/warning fixes #20

Merged
merged 1 commit into from
Jan 24, 2017
Merged

Two small strong-mode/warning fixes #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/src/stream_subscription_transformer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import 'dart:async';

import 'async_memoizer.dart';
import 'delegate/stream_subscription.dart';

typedef Future _AsyncHandler<T>(StreamSubscription<T> inner);

Expand Down Expand Up @@ -101,5 +100,5 @@ class _TransformedSubscription<T> implements StreamSubscription<T> {
}

Future/*<E>*/ asFuture/*<E>*/([/*=E*/ futureValue]) =>
_inner?.asFuture(futureValue) ?? new Completer().future;
_inner?.asFuture(futureValue) ?? new Completer/*<E>*/().future;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmesserly Shouldn't this be inferred?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. Not sure, I know we have inference for ??. Do you know what the error message was?

Copy link

@jmesserly jmesserly Jan 25, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooooooooh ... NVM, this is the bug: dart-lang/sdk#27114

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsafe implicit cast from 'Future<dynamic>' to 'Future<E>'.

}