This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Make ephemeral async cache clear sooner. #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `AsyncCache.ephemeral()` cache would invalidate the `fetch` cache after a `Duration.zero` wait. That allows a large number of microtasks to happen between the `fetch` completing and the cache being invalidated. Instead the cache is now invalidated immediately when the fetched request completes.
natebosch
approved these changes
Mar 14, 2022
Comment on lines
+66
to
+67
| return _cachedValueFuture ??= callback() | ||
| ..whenComplete(_startStaleTimer).ignore(); |
There was a problem hiding this comment.
Is this behavior change intentional? Do we still want to call _startStaleTimer if _cachedValueFuture was non-null?
Suggested change
| return _cachedValueFuture ??= callback() | |
| ..whenComplete(_startStaleTimer).ignore(); | |
| return (_cachedValueFuture ??= callback()) | |
| ..whenComplete(_startStaleTimer).ignore(); |
There was a problem hiding this comment.
I think this is actually correct, and the original wasn't. The original could trigger multiple invalidations (at the same time, _duration after the future completed, so probably not a problem). One is sufficient.
|
This LGTM, but let's hold off on merging until we figure out why an earlier change broke some tests. |
|
I believe the earlier change was fixed, so landing. |
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 14, 2024
The `AsyncCache.ephemeral()` cache would invalidate the `fetch` cache after a `Duration.zero` wait. That allows a large number of microtasks to happen between the `fetch` completing and the cache being invalidated. Instead the cache is now invalidated immediately when the fetched request completes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AsyncCache.ephemeral()cache would invalidatethe
fetchcache after aDuration.zerowait.That allows a large number of microtasks to happen between
the
fetchcompleting and the cache being invalidated.Instead the cache is now invalidated immediately when the fetched
request completes.
Fixes dart-lang/core#335