This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Deprecate AsyncCache.fetchStream.
#209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The feature complicates the `AsyncCache` class, and would be a better fit for a separate class. The functionality is not great. Since it returns the "same" stream each time the cache is queried (until evaluated), it actually caches all stream events The invalidation is tricky because the timer doesn't start until you *listen* to the stream. In practice, people will usually listen to the stream they fetch. It also seems that no-one ever used the functionality. There is no use inside Google, or in [Github](https://github.com/search?q=%22.fetchStream%22+language%3ADart+-filename%3Aasync_cache.dart+-filename%3Aasync_cache_test.dart&type=code), outside of the package's own tests. It's a better fit for a separate class, but it also appears to not be used anywhere
natebosch
approved these changes
Mar 16, 2022
natebosch
approved these changes
Mar 21, 2022
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 14, 2024
* Deprecate `AsyncCache.fetchStream`. The feature complicates the `AsyncCache` class, and would be a better fit for a separate class. The functionality is not great. Since it returns the "same" stream each time the cache is queried (until evaluated), it actually caches all stream events The invalidation is tricky because the timer doesn't start until you *listen* to the stream. In practice, people will usually listen to the stream they fetch. It also seems that no-one ever used the functionality. There is no use inside Google, or in [Github](https://github.com/search?q=%22.fetchStream%22+language%3ADart+-filename%3Aasync_cache.dart+-filename%3Aasync_cache_test.dart&type=code), outside of the package's own tests. It's a better fit for a separate class, but it also appears to not be used anywhere
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
featchStreamfeature complicates theAsyncCacheclass, and would be a better fit for a separate class.The functionality is not great. Since it returns the "same" stream each time the cache is queried (until evaluated), it actually
caches all stream events.
The invalidation is tricky because the timer doesn't start until you listen to the stream. In practice, people will usually listen to the stream they fetch.
It also seems that no-one ever used the functionality.
There is no use inside Google, or in Github, outside of the package's own tests.