This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Use FutureOr. #27
Merged
Use FutureOr. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #26
kevmoo
reviewed
Feb 14, 2017
lib/src/delegate/future.dart
Outdated
| @@ -27,7 +27,7 @@ class DelegatingFuture<T> implements Future<T> { | |||
| Future<T> catchError(Function onError, {bool test(Object error)}) => | |||
| _future.catchError(onError, test: test); | |||
|
|
|||
| Future/*<S>*/ then/*<S>*/(dynamic onValue(T value), {Function onError}) => | |||
| Future/*<S>*/ then/*<S>*/(FutureOr/*<S>*/ onValue(T value), {Function onError}) => | |||
There was a problem hiding this comment.
Might as well use full generic method syntax, too – right?
There was a problem hiding this comment.
Lasse has a separate CL out for that.
There was a problem hiding this comment.
I have landed that now, so you can update the one on FutureOr.
Hmm, I can do that directly in github. Clever. Done :)
|
LGTM |
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 14, 2024
Closes dart-lang/async#26
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes dart-lang/core#300