This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Skip typed_wrapper/stream_test #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't test this in 2.0 runtime semantics until test supports a 2.0-compatible platform (dart-lang/test#414). Closes #35
lrhn
reviewed
Sep 22, 2017
| @@ -2,6 +2,8 @@ | |||
| // for details. All rights reserved. Use of this source code is governed by a | |||
| // BSD-style license that can be found in the LICENSE file. | |||
|
|
|||
| @Skip("Re-enable this when test can run DDC (test#414).") | |||
|
|
|||
There was a problem hiding this comment.
Please add a library tag, so the annotation applies to that, not the import below. I know that it "works", but it's still ugly.
(We should allow an empty library; declaration for that use-case).
There was a problem hiding this comment.
That's contrary to the style of every other package that uses test annotations.
There was a problem hiding this comment.
Keep it then, until we make library; possible.
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 14, 2024
We can't test this in 2.0 runtime semantics until test supports a 2.0-compatible platform (dart-lang/testdart-lang/async#414). Closes dart-lang/async#35
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't test this in 2.0 runtime semantics until test supports a
2.0-compatible platform (dart-lang/test#414).
Closes dart-lang/core#304