This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Fix a StreamQueue bug #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, StreamQueueTransaction assumed that its request was the oldest request in the queue at the time at which it was committed or rejected. This assumption wasn't always correct, and this change avoids making it.
lrhn
approved these changes
Jan 5, 2018
CHANGELOG.md
Outdated
|
|
||
| * Fix a bug in `StreamQueue.startTransaction()` and related methods when | ||
| rejecting a transaction that isn't the oldest request in the queue. | ||
|
|
There was a problem hiding this comment.
Ah yes, makes sense - you can reject a transaction before it gets its first event.
| @@ -401,7 +401,7 @@ abstract class StreamQueue<T> { | |||
|
|
|||
| // ------------------------------------------------------------------ | |||
| // Methods that may be called from the request implementations to | |||
| // control the even stream. | |||
| // control the event stream. | |||
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 14, 2024
Previously, StreamQueueTransaction assumed that its request was the oldest request in the queue at the time at which it was committed or rejected. This assumption wasn't always correct, and this change avoids making it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, StreamQueueTransaction assumed that its request was the
oldest request in the queue at the time at which it was committed or
rejected. This assumption wasn't always correct, and this change
avoids making it.