This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Merge _StreamQueue into StreamQueue #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original reason to split into an abstract and concrete class was to allow other implementations that would allow for the transaction implementation. Since that was implemented without a separate subclass merge the implementation back to one class to avoid unnecessary abstraction and make it easier to debug.
|
Was originally split in https://codereview.chromium.org//1305063002 |
|
LGTM. |
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 14, 2024
The original reason to split into an abstract and concrete class was to allow other implementations that would allow for the transaction implementation. Since that was implemented without a separate subclass merge the implementation back to one class to avoid unnecessary abstraction and make it easier to debug.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original reason to split into an abstract and concrete class was to
allow other implementations that would allow for the transaction
implementation. Since that was implemented without a separate subclass
merge the implementation back to one class to avoid unnecessary
abstraction and make it easier to debug.