This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Add StreamGroup.mergeBroadcast #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Oct 3, 2019
|
|
||
| expect(merged.isBroadcast, isTrue); | ||
|
|
||
| expect(merged.toList(), completion(unorderedEquals(["first", "second"]))); |
There was a problem hiding this comment.
does this need to be an unorderedEquals check? In theory these would always come in the order they are emitted by the given streams right?
There was a problem hiding this comment.
🤷♂ - it duplicates the existing test... I'll followup on this.
jakemac53
approved these changes
Oct 3, 2019
natebosch
added a commit
that referenced
this pull request
Oct 3, 2019
See #90 (comment) Merged streams forward events synchronously so we do know that guarantees that events keep their order when forwarded. Since it's not necessary to allow for ordering changes drop the `unorderedEquals`. Also refactor to async/await from a `completion` matcher.
natebosch
added a commit
that referenced
this pull request
Oct 4, 2019
See #90 (comment) Merged streams forward events synchronously so we do know that guarantees that events keep their order when forwarded. Since it's not necessary to allow for ordering changes drop the `unorderedEquals`. Also refactor to async/await from a `completion` matcher.
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 14, 2024
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 14, 2024
See dart-archive/async#90 (comment) Merged streams forward events synchronously so we do know that guarantees that events keep their order when forwarded. Since it's not necessary to allow for ordering changes drop the `unorderedEquals`. Also refactor to async/await from a `completion` matcher.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.