Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When the build_daemon fails to start we should log the exception to the client #2259

Closed
grouma opened this issue May 9, 2019 · 3 comments
Closed

When the build_daemon fails to start we should log the exception to the client #2259

grouma opened this issue May 9, 2019 · 3 comments
Assignees
@grouma

Comments

@grouma
Copy link
Member

grouma commented May 9, 2019

I think we want to fiddle with the logic here:
https://github.com/dart-lang/build/blob/master/build_daemon/lib/client.dart#L56
@grouma grouma mentioned this issue May 9, 2019
Closed
@grouma
Copy link
Member Author

grouma commented May 10, 2019

Found out we actually log the error message. However, the message is immediately cleared due to our logging logic. This will mostly be fixed by build_daemon version 1.0.0 as the client will now log SEVERE messages which should not be cleared:
https://github.com/dart-lang/build/blob/master/build_daemon/lib/client.dart#L36

@grouma grouma self-assigned this May 10, 2019
@jakemac53
Copy link
Contributor

@grouma is this done now?

@grouma
Copy link
Member Author

grouma commented Jun 3, 2019

Yup. This is done.

@grouma grouma closed this as completed Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grouma grouma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakemac53 @grouma