Skip to content

#2559. Update augmenting_constructors_A01_* tests #3388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

#2559. Update augmenting_constructors_A01_* tests #3388

wants to merge 3 commits into from

Conversation

@sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Nov 11, 2025

  • Augmentations from parts moved to the main test to improve readability
  • Assertion text updated
  • Experimental flag changed
  • Declarations updated to avoid two completed declarations in the chain of the augmentations

eernstg
eernstg reviewed Nov 11, 2025
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, bunch of comments.

Perhaps the tests about signature mismatches should contain a larger amount of text from

https://github.com/dart-lang/language/blob/main/working/augmentations/feature-specification.md#augmenting-function-and-constructor-signatures

?

sgrekhov
sgrekhov commented Nov 12, 2025
View reviewed changes
Copy link
Contributor Author

@sgrekhov sgrekhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Updated. PTAL.

eernstg
eernstg approved these changes Nov 12, 2025
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eernstg eernstg eernstg approved these changes

@chloestefantsova chloestefantsova Awaiting requested review from chloestefantsova

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sgrekhov @eernstg