Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #3784 into an 8.0.9+1 release #3800

Merged
merged 6 commits into from
Jun 27, 2024

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Jun 27, 2024

The flutter roller is blocked and needs the fix in #3784 (14d33d3) released. Rather than cut a release with unrelated changes (with potential bugs), I'm cutting a cherry-pick release. This avoids ~10 commits between 8.0.9 and 14d33d3, and ~14 commits that have landed since the fix.

This PR actually contains three other cherry-pick commits that are necessary for CI (ddb8fb4, 3decf1e, ed97585) (CI was in a bad state right after 8.0.9 was released). They are all cherry-picked in the same order in which they appear on the main branch.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins srawlins force-pushed the eight-oh-nine-one-fix branch 2 times, most recently from 352d5ba to 3d4b6af Compare June 27, 2024 15:33
srawlins and others added 6 commits June 27, 2024 08:43
What is an aliased type parameter? Good question! `typedef TD<T> = T;` is such
an alias. The fix is pretty simple, we just weren't previously handling this
case, or being safe.
@srawlins srawlins force-pushed the eight-oh-nine-one-fix branch from 3d4b6af to cfa38d1 Compare June 27, 2024 15:43
@srawlins
Copy link
Member Author

CC @dart-lang/analyzer-team

Copy link
Member

@bwilkerson bwilkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand what's blocking the roll or why this fixes it, but I don't see anything that raises red flags, so I'm approving it. (I didn't look at the .js files. I'm hoping those are generated and don't need a review.)

@srawlins
Copy link
Member Author

Ah yeah, there isn't a ticket, as far as I know, for the roll being blocked. 🤷 But the issue appears to be that:

  1. Someone landed code in the SDK. That code can be documented with dartdoc in the SDK because dartdoc in the SDK is up-to-date.
  2. That code is rolling to flutter. Flutter does not use an up-to-date dartdoc; it uses a pub activated release from pub.
  3. So now this code is tickling the dartdoc crashes when referring to the type parameter of a generic extension type with a typedef representation type #3783 bug, fixed by Fix referencing an aliased type parameter. #3784, cherry-picked here.

@srawlins srawlins merged commit fb40d2b into dart-lang:eight-oh-nine-one Jun 27, 2024
7 checks passed
@srawlins srawlins deleted the eight-oh-nine-one-fix branch June 27, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants