fix saving of comment ids to disk

pkgs/firehose/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.5.1
+
+- Fix comment ID serialization to disk.
+
 ## 0.5.0
 
 - Split health checks in individual workflows.

pkgs/firehose/lib/src/github.dart

@@ -91,7 +91,7 @@ class GithubApi {
   /// Find a comment on the PR matching the given criteria ([user],
   /// [searchTerm]). Return the issue ID if a matching comment is found or null
   /// if there's no match.
-  Future<IssueComment?> findCommentId({
+  Future<int?> findCommentId({
     required String user,
     String? searchTerm,
   }) async {
@@ -107,7 +107,7 @@ class GithubApi {
       },
       orElse: () => null,
     );
-    return matchingComment;
+    return matchingComment?.id;
   }
 
   Future<List<GitFile>> listFilesForPR() async => await github.pullRequests

pkgs/firehose/pubspec.yaml

@@ -1,6 +1,6 @@
 name: firehose
 description: A tool to automate publishing of Pub packages from GitHub actions.
-version: 0.5.0
+version: 0.5.1
 repository: https://github.com/dart-lang/ecosystem/tree/main/pkgs/firehose
 
 environment:

pkgs/firehose/test/github_test.dart

@@ -26,14 +26,14 @@ Future<void> main() async {
   });
   test('Find comment', () async {
     var commentId = await github.findCommentId(user: 'auto-submit[bot]');
-    expect(commentId?.id, 1660891263);
+    expect(commentId, 1660891263);
   });
   test('Find comment with searchterm', () async {
     var commentId = await github.findCommentId(
       user: 'auto-submit[bot]',
       searchTerm: 'before re-applying this label.',
     );
-    expect(commentId?.id, 1660891263);
+    expect(commentId, 1660891263);
   });
   test('Find comment with searchterm', () async {
     var commentId = await github.findCommentId(