From 3ee9f61c8d9ca324f1d63b1e6cf063c9d7958042 Mon Sep 17 00:00:00 2001 From: Aart Bik Date: Thu, 8 Nov 2018 23:18:13 +0000 Subject: [PATCH] [vm/compiler] Fix bug in list inclusion test Rationale: Although not semantically disastrous, list inclusion was not properly implemented, which yielded some very hard to debug recompilations (or lack thereof) due to speculation. https://github.com/dart-lang/sdk/issues/34473 https://github.com/dart-lang/sdk/issues/34969 https://github.com/dart-lang/sdk/issues/32167 Change-Id: I54613127bd3ab93820d4a467c75e41f3df16ee7a Reviewed-on: https://dart-review.googlesource.com/c/83883 Reviewed-by: Siva Annamalai Commit-Queue: Aart Bik --- runtime/vm/compiler/backend/inliner.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runtime/vm/compiler/backend/inliner.h b/runtime/vm/compiler/backend/inliner.h index 1ca172fc0e83..a5168476a21c 100644 --- a/runtime/vm/compiler/backend/inliner.h +++ b/runtime/vm/compiler/backend/inliner.h @@ -68,7 +68,7 @@ class SpeculativeInliningPolicy { private: bool IsBlacklisted(intptr_t id) const { for (intptr_t i = 0; i < inlining_blacklist_.length(); ++i) { - if (inlining_blacklist_[i] != id) return true; + if (inlining_blacklist_[i] == id) return true; } return false; }