FileMode constructor should be private

[DartBot]

This issue was originally filed by @seaneagan

---

Is there any reason to allow custom FileModes ? If not, I would suggest changing to something like:

class FileMode {
  static final READ = const FileMode._internal(0);
  static final WRITE = const FileMode._internal(1);
  static final APPEND = const FileMode._internal(2);
  const FileMode._internal(int this._mode);
  final int _mode;

  // If still want to be able to create from int...
  factory FileMode(int mode) {
    switch(mode) {
      case 0: return FileMode.READ;
      case 1: return FileMode.WRITE;
      case 2: return FileMode.APPEND;
      default: throw new IllegalArgumentException("Invalid file mode ($mode), must be 0, 1, or 2");
    }
  }
}

This would obviate the need for checks such as the following (as found in file_impl.dart):

if (mode != FileMode.READ &&
        mode != FileMode.WRITE &&
        mode != FileMode.APPEND) {
      if (_onError != null) {
        _onError("Unknown file mode. Use FileMode.READ, FileMode.WRITE " +
                 "or FileMode.APPEND.");
        return;
      }
    }

[DartBot]

This comment was originally written by @seaneagan

---

Nice, just saw http://code.google.com/p/dart/source/detail?r=5234, which fixed this bug preemptively, :-). This can be closed.

[madsager]

Thanks for the report. :)

---

Added Fixed label.