Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build systems implementation for super-initializer parameters #48064

Closed
Tracked by #48055
devoncarew opened this issue Jan 4, 2022 · 8 comments
Closed
Tracked by #48055

build systems implementation for super-initializer parameters #48064

devoncarew opened this issue Jan 4, 2022 · 8 comments
Labels
area-build Use area-build for SDK build issues.

Comments

@devoncarew
Copy link
Member

devoncarew commented Jan 4, 2022

See #48055 for the main tracking issue.

@devoncarew devoncarew changed the title build systems implementation for super-initializer parameters (todo:) build systems implementation for super-initializer parameters Jan 4, 2022
@devoncarew devoncarew added the area-build Use area-build for SDK build issues. label Jan 4, 2022
@devoncarew
Copy link
Member Author

cc @jakemac53

@jakemac53
Copy link
Contributor

Do we expect any work here or do you just want me to make sure things work?

Also which build systems are we covering here, just build_runner and bazel?

@devoncarew
Copy link
Member Author

No work anticipated here per se - this is just a standing checklist item for new language features; some may have work required and some not. We'll just need the build system work scoped out for this feature (which may well be saying that none is expected).

Also which build systems are we covering here, just build_runner and bazel?

Yup just those two.

@jakemac53
Copy link
Contributor

Sounds good, I don't expect any work but I can validate once the features are implemented? Not sure how I could validate beforehand.

@jakemac53
Copy link
Contributor

There will be at least one small action item for bazel which is to bump the language version for null safe opted in packages to the latest. But that is trivial.

@itsjustkevin
Copy link
Contributor

@jakemac53 you mentioned that there may still be work that needs to be done to close out this issue. Is this still true, or is the work complete?

@jakemac53
Copy link
Contributor

I am not sure what the status is regarding internal, there shouldn't be any work beyond bumping the default language version for null safety packages. I don't usually manage that and I am not sure exactly who does tbh, somebody on the dart-in-google3 team probably?

For build_runner we just need to check that it works, there is no expected work there.

@jakemac53
Copy link
Contributor

I validated this morning that super parameters work with build_runner.

@parlough parlough closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-build Use area-build for SDK build issues.
Projects
None yet
Development

No branches or pull requests

4 participants