-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build systems implementation for super-initializer parameters #48064
Comments
cc @jakemac53 |
Do we expect any work here or do you just want me to make sure things work? Also which build systems are we covering here, just build_runner and bazel? |
No work anticipated here per se - this is just a standing checklist item for new language features; some may have work required and some not. We'll just need the build system work scoped out for this feature (which may well be saying that none is expected).
Yup just those two. |
Sounds good, I don't expect any work but I can validate once the features are implemented? Not sure how I could validate beforehand. |
There will be at least one small action item for bazel which is to bump the language version for null safe opted in packages to the latest. But that is trivial. |
@jakemac53 you mentioned that there may still be work that needs to be done to close out this issue. Is this still true, or is the work complete? |
I am not sure what the status is regarding internal, there shouldn't be any work beyond bumping the default language version for null safety packages. I don't usually manage that and I am not sure exactly who does tbh, somebody on the dart-in-google3 team probably? For build_runner we just need to check that it works, there is no expected work there. |
I validated this morning that super parameters work with build_runner. |
See #48055 for the main tracking issue.
The text was updated successfully, but these errors were encountered: