Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note with further resources on the choice of underscore rather than access modifier keywords in Dart. #2681

Merged
merged 2 commits into from
Oct 5, 2020

Conversation

kfish610
Copy link
Contributor

@kfish610 kfish610 commented Oct 3, 2020

Closes #2671.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Contributor has not signed the Contributor License Agreement label Oct 3, 2020
@kfish610
Copy link
Contributor Author

kfish610 commented Oct 3, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Contributor has signed the Contributor License Agreement and removed cla: no Contributor has not signed the Contributor License Agreement labels Oct 3, 2020
Copy link
Contributor

@kwalrath kwalrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after breaking on phrases (to reduce line length to <80 chars and reduce possible diffs in the future).

src/_guides/language/language-tour.md Outdated Show resolved Hide resolved
Co-authored-by: Kathy Walrath <kathyw@google.com>
@kwalrath kwalrath merged commit 2768ca4 into dart-lang:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain why Dart uses '_' for privacy rather than a keyword in the documentation.
3 participants