Try removing isolate.kill()

natebosch · natebosch · commit d65ea4d8d443 · 2024-03-22T18:10:19.000Z
At one point isolates were killed when the loader was closed as the runner is shutting down. Later the kill was moved to when the test suite is done. There was no specific comment about the `isolate.kill()` changes. https://codereview.chromium.org//1206033004 Before that the `isolate.kill` on close goes back to the original implementation of the loader. https://codereview.chromium.org//920703006 No internal tests seem to be relying on this behavior, and nothing times out when it is removed. Check whether there are any tests on CI that validate this behavior.
diff --git a/pkgs/test_core/lib/src/runner/vm/platform.dart b/pkgs/test_core/lib/src/runner/vm/platform.dart
@@ -80,7 +80,6 @@ class VMPlatform extends PlatformPlugin {
         rethrow;
       }
       outerChannel = MultiChannel(IsolateChannel.connectReceive(receivePort));
-      cleanupCallbacks.add(isolate.kill);
     }
     cleanupCallbacks.add(outerChannel.sink.close);
 

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,6 @@ class VMPlatform extends PlatformPlugin {`
`80`	`80`	`rethrow;`
`81`	`81`	`}`
`82`	`82`	`outerChannel = MultiChannel(IsolateChannel.connectReceive(receivePort));`
`83`		`- cleanupCallbacks.add(isolate.kill);`
`84`	`83`	`}`
`85`	`84`	`cleanupCallbacks.add(outerChannel.sink.close);`
`86`	`85`