diff --git a/webdev/CHANGELOG.md b/webdev/CHANGELOG.md index 8ff025c90..10354fe76 100644 --- a/webdev/CHANGELOG.md +++ b/webdev/CHANGELOG.md @@ -1,3 +1,8 @@ +## 0.1.2 + +- Remove check for `build_web_compilers`. Allows general support for + `build_runner` from tools. + ## 0.1.1 - Checks for a dependency on `build_web_compilers`. diff --git a/webdev/lib/src/pubspec.dart b/webdev/lib/src/pubspec.dart index 48836bfee..cfa14d9df 100644 --- a/webdev/lib/src/pubspec.dart +++ b/webdev/lib/src/pubspec.dart @@ -33,12 +33,6 @@ class PackageExceptionDetails { 'You must have a dependency on `build_runner` in `pubspec.yaml`. ' 'It can be in either `dependencies` or `dev_dependencies`.'); - static const noBuildWebCompilersDep = const PackageExceptionDetails._( - 'A dependency on `build_web_compilers` was not found.', - description: - 'You must have a dependency on `build_web_compilers` in `pubspec.yaml` ' - 'or transitively via another dependency.'); - @override String toString() => [error, description].join('\n'); } @@ -87,11 +81,6 @@ Future checkPubspecLock() async { } } - var buldWebCompilers = packages['build_web_compilers']; - if (buldWebCompilers == null) { - issues.add(PackageExceptionDetails.noBuildWebCompilersDep); - } - if (issues.isNotEmpty) { throw new PackageException._(issues); } diff --git a/webdev/pubspec.yaml b/webdev/pubspec.yaml index cc939efbb..8fa845ac0 100644 --- a/webdev/pubspec.yaml +++ b/webdev/pubspec.yaml @@ -1,5 +1,5 @@ name: webdev -version: 0.1.1 +version: 0.1.2-dev author: Dart Team homepage: https://github.com/dart-lang/webdev description: >- diff --git a/webdev/test/integration_test.dart b/webdev/test/integration_test.dart index e2df7fdb0..0f179ab54 100644 --- a/webdev/test/integration_test.dart +++ b/webdev/test/integration_test.dart @@ -71,29 +71,6 @@ packages: } }); - test('should fail with no `build_web_compilers` dependency', () async { - await d.file('pubspec.lock', ''' -# Copy-pasted from a valid run -packages: - build_runner: - dependency: "direct main" - description: - name: build_runner - url: "https://pub.dartlang.org" - source: hosted - version: "0.8.0" -''').create(); - - var process = await TestProcess.start('dart', [_webdevBin, 'build'], - workingDirectory: d.sandbox); - - await expectLater( - process.stdout, emits('Could not run in the current directory.')); - await expectLater(process.stdout, - emits('A dependency on `build_web_compilers` was not found.')); - await process.shouldExit(78); - }); - test('should fail gracefully if there is no .packages file', () async { await d.file('pubspec.lock', ''' # Copy-pasted from a valid run @@ -105,13 +82,6 @@ packages: url: "https://pub.dartlang.org" source: hosted version: "0.8.0" - build_web_compilers: - dependency: "direct main" - description: - name: build_web_compilers - url: "https://pub.dartlang.org" - source: hosted - version: "0.3.4+2" ''').create(); var process = await TestProcess.start('dart', [_webdevBin, 'build'], @@ -135,13 +105,6 @@ packages: url: "https://pub.dartlang.org" source: hosted version: "0.8.0" - build_web_compilers: - dependency: "direct main" - description: - name: build_web_compilers - url: "https://pub.dartlang.org" - source: hosted - version: "0.3.4+2" ''').create(); await d.file('.packages', '').create();