From 46ea61f12a03be744d6c96a3c35166f482cf240a Mon Sep 17 00:00:00 2001 From: domsteinbach Date: Mon, 30 Sep 2024 16:09:08 +0200 Subject: [PATCH 1/4] refactor: use stillImageFileValueHasExternalUrl instead of fileValueHasExternalUrl --- src/models/v2/resources/values/create/create-file-value.ts | 2 +- src/models/v2/resources/values/update/update-file-value.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/models/v2/resources/values/create/create-file-value.ts b/src/models/v2/resources/values/create/create-file-value.ts index 6ff7dd181..c466c3630 100644 --- a/src/models/v2/resources/values/create/create-file-value.ts +++ b/src/models/v2/resources/values/create/create-file-value.ts @@ -66,7 +66,7 @@ export class CreateStillImageFileValue extends CreateFileValue { */ @JsonObject("CreateStillImageExternalFileValue") export class CreateStillImageExternalFileValue extends CreateFileValue { - @JsonProperty(Constants.FileValueHasExternalUrl, String, true) + @JsonProperty(Constants.StillImageFileValueHasExternalUrl, String, true) externalUrl?: string = ""; constructor() { super(Constants.StillImageExternalFileValue); diff --git a/src/models/v2/resources/values/update/update-file-value.ts b/src/models/v2/resources/values/update/update-file-value.ts index bf82fe297..87e64a8ce 100644 --- a/src/models/v2/resources/values/update/update-file-value.ts +++ b/src/models/v2/resources/values/update/update-file-value.ts @@ -67,7 +67,7 @@ export class UpdateStillImageFileValue extends UpdateFileValue { */ @JsonObject("UpdateStillImageExternalFileValue") export class UpdateExternalStillImageFileValue extends UpdateFileValue { - @JsonProperty(Constants.FileValueHasExternalUrl, String, true) + @JsonProperty(Constants.StillImageFileValueHasExternalUrl, String, true) externalUrl: string; constructor() { super(Constants.StillImageExternalFileValue); From acb1fb3cad9d2ac3ff715c7400edd310f012fa47 Mon Sep 17 00:00:00 2001 From: domsteinbach Date: Mon, 30 Sep 2024 16:35:24 +0200 Subject: [PATCH 2/4] chore: mark as deprecated --- src/models/v2/Constants.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/models/v2/Constants.ts b/src/models/v2/Constants.ts index f0e661b88..03aec2a0a 100644 --- a/src/models/v2/Constants.ts +++ b/src/models/v2/Constants.ts @@ -129,6 +129,9 @@ export class Constants { static StillImageFileValueHasDimX = Constants.KnoraApiV2 + Constants.HashDelimiter + "stillImageFileValueHasDimX"; static StillImageFileValueHasDimY = Constants.KnoraApiV2 + Constants.HashDelimiter + "stillImageFileValueHasDimY"; static StillImageFileValueHasIIIFBaseUrl = Constants.KnoraApiV2 + Constants.HashDelimiter + "stillImageFileValueHasIIIFBaseUrl"; + /** + * @deprecated FileValueHasExternalUrl will be removed in future versions. Use StillImageFileValueHasExternalUrl instead.s + */ static FileValueHasExternalUrl = Constants.KnoraApiV2 + Constants.HashDelimiter + "fileValueHasExternalUrl"; static StillImageFileValueHasExternalUrl = Constants.KnoraApiV2 + Constants.HashDelimiter + "stillImageFileValueHasExternalUrl"; static AudioFileValueHasDuration = Constants.KnoraApiV2 + Constants.HashDelimiter + "audioFileValueHasDuration"; From 1f6b40b963a1a547d03e137e9d127d3436392f1a Mon Sep 17 00:00:00 2001 From: domsteinbach Date: Mon, 30 Sep 2024 16:43:13 +0200 Subject: [PATCH 3/4] feat: update versions --- package.json | 2 +- vars.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 2ed571a6c..4c6a2204e 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@dasch-swiss/dsp-js", - "version": "10.2.1", + "version": "10.2.2", "description": "JavaScript library that handles API requests to Knora", "main": "index.js", "files": [ diff --git a/vars.mk b/vars.mk index 8de6470a0..f9da3a978 100644 --- a/vars.mk +++ b/vars.mk @@ -6,4 +6,4 @@ else endif API_REPO := dasch-swiss/dsp-api -API_VERSION := v30.18.2 +API_VERSION := v30.18.4 From 6068a823a4175bbe5db4010a728bea4bacd276be Mon Sep 17 00:00:00 2001 From: domsteinbach Date: Mon, 30 Sep 2024 16:46:12 +0200 Subject: [PATCH 4/4] chore --- src/models/v2/Constants.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/models/v2/Constants.ts b/src/models/v2/Constants.ts index 03aec2a0a..9094bf1ba 100644 --- a/src/models/v2/Constants.ts +++ b/src/models/v2/Constants.ts @@ -130,7 +130,7 @@ export class Constants { static StillImageFileValueHasDimY = Constants.KnoraApiV2 + Constants.HashDelimiter + "stillImageFileValueHasDimY"; static StillImageFileValueHasIIIFBaseUrl = Constants.KnoraApiV2 + Constants.HashDelimiter + "stillImageFileValueHasIIIFBaseUrl"; /** - * @deprecated FileValueHasExternalUrl will be removed in future versions. Use StillImageFileValueHasExternalUrl instead.s + * @deprecated FileValueHasExternalUrl will be removed in future versions. Use StillImageFileValueHasExternalUrl instead. */ static FileValueHasExternalUrl = Constants.KnoraApiV2 + Constants.HashDelimiter + "fileValueHasExternalUrl"; static StillImageFileValueHasExternalUrl = Constants.KnoraApiV2 + Constants.HashDelimiter + "stillImageFileValueHasExternalUrl";