Commit d4202b5
committed
Merge #6761: refactor: move ChainLocks impl. to
fd8af9c refactor: abstract away ChainLocks parent implementation from signer (Kittywhiskers Van Gogh)
733f7d3 refactor: remove `Internal*()` function definitions, consolidate (Kittywhiskers Van Gogh)
e742b7b refactor: remove need for mutual access to private members (Kittywhiskers Van Gogh)
74c1b28 refactor: separate masternode mode logic into dedicated manager class (Kittywhiskers Van Gogh)
f469c46 refactor: inline single-use `ChainLocksSigningEnabled()` definition (Kittywhiskers Van Gogh)
7e0a3f8 refactor: move masternode mode logic to `chainlock/signer.{cpp,h}` (Kittywhiskers Van Gogh)
5663eac refactor: split `Cleanup()`'s masternode and non-masternode concerns (Kittywhiskers Van Gogh)
ef15fee refactor: cleanup `src/chainlock/clsig.*`, move to dedicated namespace (Kittywhiskers Van Gogh)
021062c refactor: `llmq/chainlocks.{cpp,h}` > `chainlock/chainlock.{cpp,h}` (Kittywhiskers Van Gogh)
f10912b refactor: `llmq/clsig.{cpp,h}` > `chainlock/clsig.{cpp,h}` (Kittywhiskers Van Gogh)
Pull request description:
## Additional Information
A continuation of [dash#6742](#6742), this pull request extends the same refactoring to ChainLocks, separating its masternode mode functionality to a dedicated signer object and migrating some definitions to the newly created `chainlock` namespace.
Changes are mostly move-only except for decoupling, which should be behavior-identical.
## Breaking Changes
None expected.
## Checklist
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**
- [x] I have added or updated relevant unit/integration/functional/e2e tests
- [x] I have made corresponding changes to the documentation **(note: N/A)**
- [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
ACKs for top commit:
UdjinM6:
utACK fd8af9c
Tree-SHA512: b9de697d2c3d762824449972ce206ccfca9d878a9a8c1cf38efdb9223ee563dd7305a00ebd80ddb09bc8805133b8b5e45fbbc5e472d23b4bd710454c1048be22src/chainlock/ and split masternode logic out of manager sourceFile tree
45 files changed
+662
-507
lines changed- src
- bench
- chainlock
- coinjoin
- evo
- instantsend
- interfaces
- llmq
- node
- rpc
- test
- fuzz
- util
- wallet
- rpc
- zmq
- test
- lint
- util/data
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
45 files changed
+662
-507
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
150 | 150 | | |
151 | 151 | | |
152 | 152 | | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
153 | 156 | | |
154 | 157 | | |
155 | 158 | | |
| |||
239 | 242 | | |
240 | 243 | | |
241 | 244 | | |
242 | | - | |
243 | | - | |
244 | 245 | | |
245 | 246 | | |
246 | 247 | | |
| |||
456 | 457 | | |
457 | 458 | | |
458 | 459 | | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
459 | 463 | | |
460 | 464 | | |
461 | 465 | | |
| |||
499 | 503 | | |
500 | 504 | | |
501 | 505 | | |
502 | | - | |
503 | | - | |
504 | 506 | | |
505 | 507 | | |
506 | 508 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | | - | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
0 commit comments