From cbbece3dd89b31998bdee63c2ad9c7e5889916f4 Mon Sep 17 00:00:00 2001 From: Spencer Lievens <36229929+Duality-CDOO@users.noreply.github.com> Date: Mon, 22 Oct 2018 22:12:01 +0200 Subject: [PATCH 1/2] Fix ' warning: delete called on non-final 'PeerLogicValidation' that has virtual functions but non-virtual destructor' --- src/net_processing.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/net_processing.h b/src/net_processing.h index 3e7d596a597b..cf1166167ec2 100644 --- a/src/net_processing.h +++ b/src/net_processing.h @@ -29,7 +29,7 @@ void RegisterNodeSignals(CNodeSignals& nodeSignals); /** Unregister a network node */ void UnregisterNodeSignals(CNodeSignals& nodeSignals); -class PeerLogicValidation : public CValidationInterface { +class PeerLogicValidation final : public CValidationInterface { private: CConnman* connman; From 8e0e6455e09433aeecb2a366207007406f5e575a Mon Sep 17 00:00:00 2001 From: Spencer Lievens <36229929+Duality-CDOO@users.noreply.github.com> Date: Tue, 23 Oct 2018 00:15:31 +0200 Subject: [PATCH 2/2] Add protected distructor for CValidationInterface --- src/validationinterface.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/validationinterface.h b/src/validationinterface.h index f5f5df31c043..9a86bcf29eed 100644 --- a/src/validationinterface.h +++ b/src/validationinterface.h @@ -33,6 +33,7 @@ void UnregisterAllValidationInterfaces(); class CValidationInterface { protected: + ~CValidationInterface() = default; virtual void AcceptedBlockHeader(const CBlockIndex *pindexNew) {} virtual void NotifyHeaderTip(const CBlockIndex *pindexNew, bool fInitialDownload) {} virtual void UpdatedBlockTip(const CBlockIndex *pindexNew, const CBlockIndex *pindexFork, bool fInitialDownload) {}