backport: merge bitcoin#21732, #21762, #21754, #21953, #21850, #22633, #22738, #23154, #23721, #24002, #24197, merge bitcoin-core/gui#399 (auxiliary backports: part 14)

[kwvg]

Additional Information

• Dependency for backport: merge bitcoin#22840, #22937, #23446, #23522, #24026, #24104, #24167, #20744, partial bitcoin#23469, #24169 (replace boost::filesystem with std::filesystem) #6138

• In bitcoin#21754, the scriptSig padding multiplier (24) differs from upstream (35) as the vsize value it corresponds to must match what is ordinarily generated (85 vs 96 upstream) in order to fulfill an assertion (source).

• In bitcoin#21953, the hash associated with height 200 is generated like this (this is the same method used in dash#5236):

  • Add the height desired to the CRegTestParams::m_assumeutxo_data map with a garbage hash value (like uint256::ONE). This is to avoid an unrecognized metadata failure (source) caused by looking through the map to see if the height's there.
  • Change the LogPrintf(..) in the serialized hash check error log message located here to a std::cout << strprintf(..)
  • Edit the value of mineBlocks here to be 100 blocks less than the desired height.
  • Compile Dash Core and run ./src/test/test_dash -t validation_chainstatemanager_tests
  • Take the got value printed to your terminal window/stdout (the expected value should be our garbage value from earlier, ignore that). That's your good hash.
  • Update the CRegTestParams::m_assumeutxo_data map entry with the correct entry, reverse every change except the map entry (for obvious reasons) and the mineBlocks change.
    • Remember to add/update the hash here in validation_tests, it simply tests the hardcoded chainparams value with its own hardcoded value. That's also why we don't use this test since it'll just regurgitate the garbage values we give it.
  • Compile and re-run the test. If it passes, your hash is good. Revert the mineBlocks change.
  • Profit?

Breaking Changes

None expected.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas (note: N/A)
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation (note: N/A)
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[UdjinM6]

pls see https://github.com/UdjinM6/dash/commits/pr_6137/ (CI: https://gitlab.com/UdjinM6/dash/-/pipelines/1382702435)

pls note that 22501 and 397b432 are also parts of #6133, 22619 is a part of #6071

[UdjinM6]

utACK 1c5ea38

[PastaPastaPasta]

utACK 1c5ea38

[knst]

missing changes in contrib/signet/miner - should be partial bitcoin#22633

[knst]

nit: https://github.com/dashpay/dash-issues/issues/36 can be added here