From 80f1060757786d96bf384fae3694e11910c1b180 Mon Sep 17 00:00:00 2001
From: Konstantin Akimov <knstqq@gmail.com>
Date: Thu, 2 Oct 2025 23:48:00 +0700
Subject: [PATCH 01/10] fix: missing changes from 20459

---
 src/rpc/util.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/rpc/util.cpp b/src/rpc/util.cpp
index 60d7ddd10104..afbf34ca7e0c 100644
--- a/src/rpc/util.cpp
+++ b/src/rpc/util.cpp
@@ -536,7 +536,9 @@ UniValue RPCHelpMan::HandleRequest(const JSONRPCRequest& request) const
     if (request.mode == JSONRPCRequest::GET_HELP || !IsValidNumArgs(request.params.size())) {
         throw std::runtime_error(ToString());
     }
-    return m_fun(*this, request);
+    const UniValue ret = m_fun(*this, request);
+    CHECK_NONFATAL(std::any_of(m_results.m_results.begin(), m_results.m_results.end(), [ret](const RPCResult& res) { return res.MatchesType(ret); }));
+    return ret;
 }
 
 bool RPCHelpMan::IsValidNumArgs(size_t num_args) const

From 5f683dc513d7626df29c2e090629ec7b0014dc48 Mon Sep 17 00:00:00 2001
From: MacroFake <falke.marco@gmail.com>
Date: Thu, 19 May 2022 06:44:08 +0200
Subject: [PATCH 02/10] Merge bitcoin/bitcoin#25161: rpc: Put undocumented JSON
 failure mode behind a runtime flag

b953ea6cc691ba61bf08eb186e76e7e8b7ba8120 rpc: Put undocumented JSON failure mode behind a runtime flag (Suhail Saqan)

Pull request description:

  Fixes #24695 (Put undocumented JSON failure mode behind a runtime flag)

ACKs for top commit:
  luke-jr:
    utACK b953ea6cc691ba61bf08eb186e76e7e8b7ba8120
  vincenzopalazzo:
    ACK https://github.com/bitcoin/bitcoin/pull/25161/commits/b953ea6cc691ba61bf08eb186e76e7e8b7ba8120

Tree-SHA512: 2005ee1b1f3b637918390b2ecd4166f2fd8c86e3c59fba3da8a0cbd5b1dffd03190c92f6dca3c489ecce4276eaf3108b2edcf9cd6224b713adb52f5bb848163b
---
 src/init.cpp                           | 1 +
 src/rpc/util.cpp                       | 6 ++++--
 src/rpc/util.h                         | 2 ++
 test/functional/test_framework/util.py | 1 +
 4 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/init.cpp b/src/init.cpp
index 18d1cafe92c8..cb7eda0f5d3d 100644
--- a/src/init.cpp
+++ b/src/init.cpp
@@ -775,6 +775,7 @@ void SetupServerArgs(ArgsManager& argsman)
     argsman.AddArg("-rpcallowip=<ip>", "Allow JSON-RPC connections from specified source. Valid values for <ip> are a single IP (e.g. 1.2.3.4), a network/netmask (e.g. 1.2.3.4/255.255.255.0), a network/CIDR (e.g. 1.2.3.4/24), all ipv4 (0.0.0.0/0), or all ipv6 (::/0). This option can be specified multiple times", ArgsManager::ALLOW_ANY, OptionsCategory::RPC);
     argsman.AddArg("-rpcauth=<userpw>", "Username and HMAC-SHA-256 hashed password for JSON-RPC connections. The field <userpw> comes in the format: <USERNAME>:<SALT>$<HASH>. A canonical python script is included in share/rpcuser. The client then connects normally using the rpcuser=<USERNAME>/rpcpassword=<PASSWORD> pair of arguments. This option can be specified multiple times", ArgsManager::ALLOW_ANY | ArgsManager::SENSITIVE, OptionsCategory::RPC);
     argsman.AddArg("-rpcbind=<addr>[:port]", "Bind to given address to listen for JSON-RPC connections. Do not expose the RPC server to untrusted networks such as the public internet! This option is ignored unless -rpcallowip is also passed. Port is optional and overrides -rpcport. Use [host]:port notation for IPv6. This option can be specified multiple times (default: 127.0.0.1 and ::1 i.e., localhost, or if -rpcallowip has been specified, 0.0.0.0 and :: i.e., all addresses)", ArgsManager::ALLOW_ANY | ArgsManager::NETWORK_ONLY, OptionsCategory::RPC);
+    argsman.AddArg("-rpcdoccheck", strprintf("Throw a non-fatal error at runtime if the documentation for an RPC is incorrect (default: %u)", DEFAULT_RPC_DOC_CHECK), ArgsManager::ALLOW_ANY | ArgsManager::DEBUG_ONLY, OptionsCategory::RPC);
     argsman.AddArg("-rpccookiefile=<loc>", "Location of the auth cookie. Relative paths will be prefixed by a net-specific datadir location. (default: data dir)", ArgsManager::ALLOW_ANY, OptionsCategory::RPC);
     argsman.AddArg("-rpcexternaluser=<users>", "List of comma-separated usernames for JSON-RPC external connections", ArgsManager::ALLOW_ANY | ArgsManager::SENSITIVE, OptionsCategory::RPC);
     argsman.AddArg("-rpcexternalworkqueue=<n>", strprintf("Set the depth of the work queue to service external RPC calls (default: %d)", DEFAULT_HTTP_WORKQUEUE), ArgsManager::ALLOW_ANY | ArgsManager::DEBUG_ONLY, OptionsCategory::RPC);
diff --git a/src/rpc/util.cpp b/src/rpc/util.cpp
index afbf34ca7e0c..69f8ae73c599 100644
--- a/src/rpc/util.cpp
+++ b/src/rpc/util.cpp
@@ -12,9 +12,9 @@
 #include <script/signingprovider.h>
 #include <tinyformat.h>
 #include <util/check.h>
-#include <util/system.h>
 #include <util/strencodings.h>
 #include <util/string.h>
+#include <util/system.h>
 #include <util/translation.h>
 
 const std::string UNIX_EPOCH_TIME = "UNIX epoch time";
@@ -537,7 +537,9 @@ UniValue RPCHelpMan::HandleRequest(const JSONRPCRequest& request) const
         throw std::runtime_error(ToString());
     }
     const UniValue ret = m_fun(*this, request);
-    CHECK_NONFATAL(std::any_of(m_results.m_results.begin(), m_results.m_results.end(), [ret](const RPCResult& res) { return res.MatchesType(ret); }));
+    if (gArgs.GetBoolArg("-rpcdoccheck", DEFAULT_RPC_DOC_CHECK)) {
+        CHECK_NONFATAL(std::any_of(m_results.m_results.begin(), m_results.m_results.end(), [ret](const RPCResult& res) { return res.MatchesType(ret); }));
+    }
     return ret;
 }
 
diff --git a/src/rpc/util.h b/src/rpc/util.h
index a9f5d6246fd1..006125b749c9 100644
--- a/src/rpc/util.h
+++ b/src/rpc/util.h
@@ -23,6 +23,8 @@
 #include <variant>
 #include <vector>
 
+static constexpr bool DEFAULT_RPC_DOC_CHECK{false};
+
 /**
  * String used to describe UNIX epoch time in documentation, factored out to a
  * constant for consistency.
diff --git a/test/functional/test_framework/util.py b/test/functional/test_framework/util.py
index 107bd72cc6c3..7b9cfbd56b0d 100644
--- a/test/functional/test_framework/util.py
+++ b/test/functional/test_framework/util.py
@@ -390,6 +390,7 @@ def write_config(config_path, *, n, chain, extra_config="", disable_autoconnect=
             f.write("[{}]\n".format(chain_name_conf_section))
         f.write("port=" + str(p2p_port(n)) + "\n")
         f.write("rpcport=" + str(rpc_port(n)) + "\n")
+        f.write("rpcdoccheck=1\n")
         f.write("fallbackfee=0.00001\n")
         f.write("server=1\n")
         f.write("keypool=1\n")

From ef554040418daf8aa1d4a2730784bdb5434ccf79 Mon Sep 17 00:00:00 2001
From: fanquake <fanquake@gmail.com>
Date: Fri, 20 May 2022 08:32:41 +0100
Subject: [PATCH 03/10] Merge bitcoin/bitcoin#25170: build: Enable
 RPC_DOC_CHECK on --enable-debug

fafae678f6cd8aaca2be8ece501b258160f7fbfa build: Enable RPC_DOC_CHECK on --enable-debug (MacroFake)

Pull request description:

  This probably makes no large difference, as the setting is already enabled by default in the functional tests. However, I think it is nice to also enable it in debug builds by default to catch issues while manually testing without the runtime flags specified.

  See also https://github.com/bitcoin/bitcoin/issues/24709

ACKs for top commit:
  vincenzopalazzo:
    utACK https://github.com/bitcoin/bitcoin/pull/25170/commits/fafae678f6cd8aaca2be8ece501b258160f7fbfa

Tree-SHA512: cea3276fc9b5a3bc0f6d9819be9a50b19ecf762729d3e3975abdf00da06beaa3f664b18a826fbab1fedd9143bc0624a95a490bfe40c4b5b0a0f94dbc565ce738
---
 configure.ac   | 1 +
 src/rpc/util.h | 8 +++++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index d216ffd04eba..a1915299946b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -375,6 +375,7 @@ if test "$enable_debug" = "yes"; then
   AX_CHECK_PREPROC_FLAG([-DDEBUG_CORE], [DEBUG_CPPFLAGS="$DEBUG_CPPFLAGS -DDEBUG_CORE"], [], [$CXXFLAG_WERROR])
   AX_CHECK_PREPROC_FLAG([-DDEBUG_LOCKORDER], [DEBUG_CPPFLAGS="$DEBUG_CPPFLAGS -DDEBUG_LOCKORDER"], [], [$CXXFLAG_WERROR])
   AX_CHECK_PREPROC_FLAG([-DDEBUG_LOCKCONTENTION], [DEBUG_CPPFLAGS="$DEBUG_CPPFLAGS -DDEBUG_LOCKCONTENTION"], [], [$CXXFLAG_WERROR])
+  AX_CHECK_PREPROC_FLAG([-DRPC_DOC_CHECK], [DEBUG_CPPFLAGS="$DEBUG_CPPFLAGS -DRPC_DOC_CHECK"], [], [$CXXFLAG_WERROR])
   AX_CHECK_PREPROC_FLAG([-DABORT_ON_FAILED_ASSUME], [DEBUG_CPPFLAGS="$DEBUG_CPPFLAGS -DABORT_ON_FAILED_ASSUME"], [], [$CXXFLAG_WERROR])
   AX_CHECK_COMPILE_FLAG([-ftrapv], [DEBUG_CXXFLAGS="$DEBUG_CXXFLAGS -ftrapv"], [], [$CXXFLAG_WERROR])
 else
diff --git a/src/rpc/util.h b/src/rpc/util.h
index 006125b749c9..09cba33b813e 100644
--- a/src/rpc/util.h
+++ b/src/rpc/util.h
@@ -23,7 +23,13 @@
 #include <variant>
 #include <vector>
 
-static constexpr bool DEFAULT_RPC_DOC_CHECK{false};
+static constexpr bool DEFAULT_RPC_DOC_CHECK{
+#ifdef RPC_DOC_CHECK
+    true
+#else
+    false
+#endif
+};
 
 /**
  * String used to describe UNIX epoch time in documentation, factored out to a

From 9d93d5930f1ed6ca93dd044e3d3e22f571620797 Mon Sep 17 00:00:00 2001
From: fanquake <fanquake@gmail.com>
Date: Mon, 30 May 2022 09:15:50 +0100
Subject: [PATCH 04/10] Merge bitcoin/bitcoin#25237: rpc: Capture UniValue by
 ref for rpcdoccheck

20ff4991e548630d7bb5e491fa4d69ec49369872 rpc: Capture potentially large UniValue by ref for rpcdoccheck (Martin Zumsande)

Pull request description:

  Capturing it by reference instead of value should save us from making a copy of a potentially large object. Saw this while having a look at #25229 although I couldn't reproduce an actual leak, so this is not a fix for that issue.

ACKs for top commit:
  MarcoFalke:
    review ACK 20ff4991e548630d7bb5e491fa4d69ec49369872
  theStack:
    Code-review ACK 20ff4991e548630d7bb5e491fa4d69ec49369872
  furszy:
    Code ACK 20ff4991

Tree-SHA512: faf7bb14e37f8324b93a39095b07693626329da47c4a1ac8929bf99385e2e0567008e959e7e8540bc7d454d08fa41cccd39f55253c9a839fa88362922058a93b
---
 src/rpc/util.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/rpc/util.cpp b/src/rpc/util.cpp
index 69f8ae73c599..da552c410f5f 100644
--- a/src/rpc/util.cpp
+++ b/src/rpc/util.cpp
@@ -538,7 +538,7 @@ UniValue RPCHelpMan::HandleRequest(const JSONRPCRequest& request) const
     }
     const UniValue ret = m_fun(*this, request);
     if (gArgs.GetBoolArg("-rpcdoccheck", DEFAULT_RPC_DOC_CHECK)) {
-        CHECK_NONFATAL(std::any_of(m_results.m_results.begin(), m_results.m_results.end(), [ret](const RPCResult& res) { return res.MatchesType(ret); }));
+        CHECK_NONFATAL(std::any_of(m_results.m_results.begin(), m_results.m_results.end(), [&ret](const RPCResult& res) { return res.MatchesType(ret); }));
     }
     return ret;
 }

From f4d8b03c1b17507143cb18899f561a7973c656c1 Mon Sep 17 00:00:00 2001
From: Konstantin Akimov <knstqq@gmail.com>
Date: Sat, 25 Oct 2025 03:48:29 +0700
Subject: [PATCH 05/10] fix: extra fixes for rpc helps as follow-up for
 dash#6886

---
 src/rpc/quorums.cpp | 24 ++++++++++++++++++++++--
 1 file changed, 22 insertions(+), 2 deletions(-)

diff --git a/src/rpc/quorums.cpp b/src/rpc/quorums.cpp
index be9eb66a3d7f..f80a04e8d30c 100644
--- a/src/rpc/quorums.cpp
+++ b/src/rpc/quorums.cpp
@@ -246,7 +246,27 @@ static RPCHelpMan quorum_info()
         RPCResult{
             RPCResult::Type::OBJ, "", "",
             {
-                {RPCResult::Type::ELISION, "", ""}
+                {RPCResult::Type::NUM, "height", "Quorum Height"},
+                {RPCResult::Type::STR, "type", "Quorum type"},
+                {RPCResult::Type::STR_HEX, "quorumHash", "Quorum hash"},
+                {RPCResult::Type::NUM, "quorumIndex", "Quorum index (applicable only to rotated quorums)."},
+                {RPCResult::Type::STR_HEX, "minedBlock", "Blockhash where the commitment was mined."},
+                {RPCResult::Type::NUM, "previousConsecutiveDKGFailures", "Number of previous consecutive DKG failures."},
+                {RPCResult::Type::ARR, "members", "Members of quorum",
+                    {
+                        {RPCResult::Type::OBJ, "", "",
+                        {
+                            {RPCResult::Type::STR_HEX, "proTxHash", "ProTx of collaterial"},
+                            {RPCResult::Type::NUM, "service", "Address of node. Legacy, will be deprecated in further versions. See `addresses` instead."},
+                            {RPCResult::Type::ARR, "addresses", "Addresses of node",
+                                // TODO - expand it when extended addresses are fully implemented
+                                {{RPCResult::Type::ELISION, "", ""}},
+                            },
+                            {RPCResult::Type::STR_HEX, "pubKeyOperator", "The operator BLS public key"},
+                            {RPCResult::Type::BOOL, "valid", "True is member valid for this DKG"}
+                        }},
+                    },
+                },
             },
         },
         RPCExamples{""},
@@ -427,7 +447,7 @@ static RPCHelpMan quorum_memberof()
             {
                 {RPCResult::Type::OBJ, "", "Quorum Info",
                 {
-                    {RPCResult::Type::ELISION, "", "See for details help for `quorum info`"},
+                    {RPCResult::Type::ELISION, "", "See `help quorum info` for details"},
                     {RPCResult::Type::BOOL, "isValidMember", ""},
                     {RPCResult::Type::NUM, "memberIndex", ""},
                 }},

From 5fe76efd4e6fbbb8ddda686b4e908e689a3b79c9 Mon Sep 17 00:00:00 2001
From: Konstantin Akimov <knstqq@gmail.com>
Date: Sun, 26 Oct 2025 01:46:54 +0700
Subject: [PATCH 06/10] fix: typo mineable/minable commitments in rpc doc

---
 src/rpc/quorums.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/rpc/quorums.cpp b/src/rpc/quorums.cpp
index f80a04e8d30c..e17c91aac931 100644
--- a/src/rpc/quorums.cpp
+++ b/src/rpc/quorums.cpp
@@ -329,7 +329,7 @@ static RPCHelpMan quorum_dkgstatus()
                     // TODO: list fields of output for RPC help instead ELISION
                     {{RPCResult::Type::ELISION, "", ""}},
                 },
-                {RPCResult::Type::ARR, "mineableCommitments", "",
+                {RPCResult::Type::ARR, "minableCommitments", "",
                     // TODO: list fields of output for RPC help instead ELISION
                     {{RPCResult::Type::ELISION, "", ""}},
                 },

From 35ea486f8bef9880f8ccb41a089de2317a4bbafe Mon Sep 17 00:00:00 2001
From: Konstantin Akimov <knstqq@gmail.com>
Date: Sun, 26 Oct 2025 03:11:09 +0700
Subject: [PATCH 07/10] fix: typo NUM/STR for "service" in rpc help

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
---
 src/rpc/quorums.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/rpc/quorums.cpp b/src/rpc/quorums.cpp
index e17c91aac931..99b2258162e9 100644
--- a/src/rpc/quorums.cpp
+++ b/src/rpc/quorums.cpp
@@ -257,7 +257,7 @@ static RPCHelpMan quorum_info()
                         {RPCResult::Type::OBJ, "", "",
                         {
                             {RPCResult::Type::STR_HEX, "proTxHash", "ProTx of collaterial"},
-                            {RPCResult::Type::NUM, "service", "Address of node. Legacy, will be deprecated in further versions. See `addresses` instead."},
+                            {RPCResult::Type::STR, "service", "Address of node. Legacy, will be deprecated in further versions. See `addresses` instead."},
                             {RPCResult::Type::ARR, "addresses", "Addresses of node",
                                 // TODO - expand it when extended addresses are fully implemented
                                 {{RPCResult::Type::ELISION, "", ""}},

From 9382fc22d64246d346b3b0f1bbb5db78bc0f5108 Mon Sep 17 00:00:00 2001
From: Konstantin Akimov <knstqq@gmail.com>
Date: Mon, 3 Nov 2025 15:06:04 +0700
Subject: [PATCH 08/10] refactor: use GetRpcResult helper to avoid duplicated
 string literals for rpc help

---
 src/evo/core_write.cpp |  1 +
 src/rpc/quorums.cpp    | 15 ++++++---------
 2 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/src/evo/core_write.cpp b/src/evo/core_write.cpp
index 4e83e8bc4630..0779abe51893 100644
--- a/src/evo/core_write.cpp
+++ b/src/evo/core_write.cpp
@@ -58,6 +58,7 @@ const std::map<std::string, RPCResult> RPCRESULT_MAP{{
     RESULT_MAP_ENTRY("PoSeRevivedHeight", RPCResult::Type::NUM, "Height masternode recovered from Proof of Service violations"),
     RESULT_MAP_ENTRY("proTxHash", RPCResult::Type::STR_HEX, "Hash of the masternode's initial ProRegTx"),
     RESULT_MAP_ENTRY("pubKeyOperator", RPCResult::Type::STR, "BLS public key used for operator signing"),
+    RESULT_MAP_ENTRY("quorumIndex", RPCResult::Type::NUM, "Quorum index. Relevant for rotation quorums only, 0 for non-rotating quorums"),
     RESULT_MAP_ENTRY("quorumHash", RPCResult::Type::STR_HEX, "Hash of the quorum"),
     RESULT_MAP_ENTRY("quorumSig", RPCResult::Type::STR_HEX, "BLS recovered threshold signature of quorum"),
     RESULT_MAP_ENTRY("registeredHeight", RPCResult::Type::NUM, "Height masternode was registered"),
diff --git a/src/rpc/quorums.cpp b/src/rpc/quorums.cpp
index 99b2258162e9..540f8cfa46a1 100644
--- a/src/rpc/quorums.cpp
+++ b/src/rpc/quorums.cpp
@@ -248,7 +248,7 @@ static RPCHelpMan quorum_info()
             {
                 {RPCResult::Type::NUM, "height", "Quorum Height"},
                 {RPCResult::Type::STR, "type", "Quorum type"},
-                {RPCResult::Type::STR_HEX, "quorumHash", "Quorum hash"},
+                GetRpcResult("quorumHash"),
                 {RPCResult::Type::NUM, "quorumIndex", "Quorum index (applicable only to rotated quorums)."},
                 {RPCResult::Type::STR_HEX, "minedBlock", "Blockhash where the commitment was mined."},
                 {RPCResult::Type::NUM, "previousConsecutiveDKGFailures", "Number of previous consecutive DKG failures."},
@@ -256,13 +256,10 @@ static RPCHelpMan quorum_info()
                     {
                         {RPCResult::Type::OBJ, "", "",
                         {
-                            {RPCResult::Type::STR_HEX, "proTxHash", "ProTx of collaterial"},
-                            {RPCResult::Type::STR, "service", "Address of node. Legacy, will be deprecated in further versions. See `addresses` instead."},
-                            {RPCResult::Type::ARR, "addresses", "Addresses of node",
-                                // TODO - expand it when extended addresses are fully implemented
-                                {{RPCResult::Type::ELISION, "", ""}},
-                            },
-                            {RPCResult::Type::STR_HEX, "pubKeyOperator", "The operator BLS public key"},
+                            GetRpcResult("proTxHash"),
+                            GetRpcResult("service"),
+                            GetRpcResult("addresses"),
+                            GetRpcResult("pubKeyOperator"),
                             {RPCResult::Type::BOOL, "valid", "True is member valid for this DKG"}
                         }},
                     },
@@ -316,7 +313,7 @@ static RPCHelpMan quorum_dkgstatus()
                         {RPCResult::Type::OBJ, "", "",
                         {
                             {RPCResult::Type::NUM, "llmqType", "Name of quorum"},
-                            {RPCResult::Type::NUM, "quorumIndex", "Relevant for rotation quorums only, 0 for non-rotating quorums"},
+                            GetRpcResult("quorumIndex"),
                             {RPCResult::Type::OBJ, "status", "",
                             {
                                 // TODO: list fields of output for RPC help instead ELISION

From 2883bdd5c5aef719108607a65013b8952b871e50 Mon Sep 17 00:00:00 2001
From: Konstantin Akimov <knstqq@gmail.com>
Date: Tue, 4 Nov 2025 02:58:55 +0700
Subject: [PATCH 09/10] fix: refactor one more missing `quorumIndex` usage to
 GetRpcResult

Co-authored-by: Kittywhiskers Van Gogh <63189531+kwvg@users.noreply.github.com>
---
 src/rpc/quorums.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/rpc/quorums.cpp b/src/rpc/quorums.cpp
index 540f8cfa46a1..92e578476b47 100644
--- a/src/rpc/quorums.cpp
+++ b/src/rpc/quorums.cpp
@@ -249,7 +249,7 @@ static RPCHelpMan quorum_info()
                 {RPCResult::Type::NUM, "height", "Quorum Height"},
                 {RPCResult::Type::STR, "type", "Quorum type"},
                 GetRpcResult("quorumHash"),
-                {RPCResult::Type::NUM, "quorumIndex", "Quorum index (applicable only to rotated quorums)."},
+                GetRpcResult("quorumIndex"),
                 {RPCResult::Type::STR_HEX, "minedBlock", "Blockhash where the commitment was mined."},
                 {RPCResult::Type::NUM, "previousConsecutiveDKGFailures", "Number of previous consecutive DKG failures."},
                 {RPCResult::Type::ARR, "members", "Members of quorum",

From 449d7fa15fc700c0d878bdfb301e9a4df9c1df6f Mon Sep 17 00:00:00 2001
From: Konstantin Akimov <knstqq@gmail.com>
Date: Thu, 13 Nov 2025 17:33:09 +0700
Subject: [PATCH 10/10] fix: review comments for rpc/quorums help

---
 src/rpc/quorums.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/rpc/quorums.cpp b/src/rpc/quorums.cpp
index 92e578476b47..de50c24b570e 100644
--- a/src/rpc/quorums.cpp
+++ b/src/rpc/quorums.cpp
@@ -251,7 +251,7 @@ static RPCHelpMan quorum_info()
                 GetRpcResult("quorumHash"),
                 GetRpcResult("quorumIndex"),
                 {RPCResult::Type::STR_HEX, "minedBlock", "Blockhash where the commitment was mined."},
-                {RPCResult::Type::NUM, "previousConsecutiveDKGFailures", "Number of previous consecutive DKG failures."},
+                {RPCResult::Type::NUM, "previousConsecutiveDKGFailures", "Number of previous consecutive DKG failures. Only present for rotation-enabled quorums."},
                 {RPCResult::Type::ARR, "members", "Members of quorum",
                     {
                         {RPCResult::Type::OBJ, "", "",
@@ -260,7 +260,8 @@ static RPCHelpMan quorum_info()
                             GetRpcResult("service"),
                             GetRpcResult("addresses"),
                             GetRpcResult("pubKeyOperator"),
-                            {RPCResult::Type::BOOL, "valid", "True is member valid for this DKG"}
+                            {RPCResult::Type::BOOL, "valid", "True if member is valid for this DKG"},
+                            {RPCResult::Type::STR_HEX, "pubKeyShare", /*optional=*/true, "Share of BLS public key of the member. Only present if member is valid."}
                         }},
                     },
                 },