V0.12.1.x - dashified the about icons #759
Conversation
|
Nicely spotted, thanks! Can you squash commits into one and push the clean one (-f) again pls? |
|
Googling. Not sure how to do that. Standby. |
|
Eegad... my repo is all hosed now. Hmm. |
|
Fixed... with @moocowmoo's help cuz I am git-challenged. |
|
Looks good now, ACK a9a9c9a :) |
|
Unfortunately this change will (most probably) be superseeded by https://github.com/crowning-/dash/tree/UI_Icons because of #762. Those black/transparent icons introduced by the Bitcoin-devs are almost invisible on some Linux flavors, and don't look good on other operating systems depending on the OS-version and/or chosen UI-theme of the operating system. No idea why they did this, especially why they did this only for a couple of icons and not ALL of them. Makes the look quite inconsistent. I will create a pull request later today (with screenshots of the results) when my testing for OSX is done. We can discuss things there... Edit: done, see #764 |
|
I agree with @crowning- - black icons look weird on default ubuntu scheme :( If I broke smth while Iwas merging bitcoin source and icons actually look good on linux for bitcoin - please, let me know. Otherwise I would prefer #764 over this one. |
|
Closing due to duplication with #764 |
Swapped out some icons. For example, open dash-qt, go to "help" and "about dash" and note the "bitcoin" icon there now. This fixes that.