-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing light theme #778
Fixing light theme #778
Conversation
- colorized few images/icons to use “Strong blue” #1c75bc - replaced "smile" icon with pick-axe - fixed ds status overlap - trying to make theme less "heavy" - fewer bold labels, lighter colors for labels - removed unused files
Hi udjin, AjM here. Sorry to bother you, but...
|
@akijuh yes, I'm aware of these issues but the have nothing to do with light theme and this PR ;) |
Yep, but you have some nice gui pics in here :) |
https://github.com/dashpay/dash/blob/v0.12.1.x/CONTRIBUTING.md#pull-request-philosophy 😉 |
I like the new icons 👍 I'm not 100% if we should really reduce to only one single blue....dash.org has 2 different blues, and if I remember correctly salmion explicitly decided to use the same 2 blues. |
@crowning- there is actually second blue - for buttons it's slightly different ;) |
Mining1! :-) |
Both icon set looks good, but why they need to be so BIG in the overview tab > latest transaction list? |
Mining1 While I love the pickaxe/shovel combination on the overview-page the tiny version on the transaction-page looks too busy.The single pickaxe looks better there. |
Ok, thanks for voting :)
It's the same size for every theme sooo... |
I think we can merge this now and merge #777 as well. Is there anything else that needs to be fixed in this theme? |
One late note... Send tab icon arrow point UP, but in transactions icon point RIGHT. Shouldnt these icons need to be equal style? Edit: I mean, point in the same direction. |
Well spotted. My logic on this was that incoming transaction point inward and outgoing point outward. trivial to make new ones if you all disagree. |
I'd like to keep it the way it is because every theme uses this logic actually and I think it would be better to change them all at once in another PR if needed. |
@akijuh good find! Applies to Windows 8.1 32bit as well - and Transactions and Masternodes are truncated too. |
Fixing light theme:
old overview screen:
new one:
other screens (haven't made screenshots for current version, only have for new one, sorry)