Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing light theme #778

Merged
merged 2 commits into from
May 19, 2016
Merged

Fixing light theme #778

merged 2 commits into from
May 19, 2016

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented May 12, 2016

Fixing light theme:

  • colorized few images/icons to use “Strong blue” #1c75bc
  • replaced "smile" icon with pick-axe
  • fixed ds status overlap
  • trying to make theme less "heavy" - fewer bold labels, lighter colors for labels
  • removed unused files

old overview screen:
screen shot 2016-05-12 at 13 55 25

new one:
screen shot 2016-05-12 at 16 15 40

other screens (haven't made screenshots for current version, only have for new one, sorry)

screen shot 2016-05-12 at 17 07 40

screen shot 2016-05-12 at 17 07 50

screen shot 2016-05-12 at 17 07 59

- colorized few images/icons to use “Strong blue” #1c75bc
- replaced "smile" icon with pick-axe
- fixed ds status overlap
- trying to make theme less "heavy" - fewer bold labels, lighter colors for labels
- removed unused files
@akijuh
Copy link

akijuh commented May 12, 2016

Hi udjin, AjM here.

Sorry to bother you, but...

  • in transactions tab: columns and titles are not in the same width.
  • In Masternodes tab: some columns titles are not wide enough,
    and 'All masternodes' masternode first letter should be capital letter, like 'My Masternodes'

@UdjinM6
Copy link
Author

UdjinM6 commented May 12, 2016

@akijuh yes, I'm aware of these issues but the have nothing to do with light theme and this PR ;)
Let's fix them somewhere else.

@akijuh
Copy link

akijuh commented May 12, 2016

Yep, but you have some nice gui pics in here :)

@UdjinM6
Copy link
Author

UdjinM6 commented May 12, 2016

@akijuh

Yep, but you have some nice gui pics in here :)

https://github.com/dashpay/dash/blob/v0.12.1.x/CONTRIBUTING.md#pull-request-philosophy 😉

@crowning-
Copy link

I like the new icons 👍

I'm not 100% if we should really reduce to only one single blue....dash.org has 2 different blues, and if I remember correctly salmion explicitly decided to use the same 2 blues.

@UdjinM6
Copy link
Author

UdjinM6 commented May 12, 2016

@crowning- there is actually second blue - for buttons it's slightly different ;)

@salmion
Copy link

salmion commented May 12, 2016

These will look a look better :)

tx_out
tx_mined
tx_mined_
tx_inout
tx_in

@UdjinM6
Copy link
Author

UdjinM6 commented May 13, 2016

Allright, more screenshots :)

Mining1
screen shot 2016-05-13 at 4 01 49
screen shot 2016-05-13 at 4 01 59

Mining2
screen shot 2016-05-13 at 4 04 43
screen shot 2016-05-13 at 4 04 52

Which one to commit? Should we submit a proposal to ask masternodes? 😄

@snogcel
Copy link

snogcel commented May 13, 2016

Mining1! :-)

@akijuh
Copy link

akijuh commented May 13, 2016

Both icon set looks good, but why they need to be so BIG in the overview tab > latest transaction list?

@crowning-
Copy link

Mining1

While I love the pickaxe/shovel combination on the overview-page the tiny version on the transaction-page looks too busy.The single pickaxe looks better there.

@UdjinM6
Copy link
Author

UdjinM6 commented May 13, 2016

Ok, thanks for voting :)
Pushed new icons (mining1)

but why they need to be so BIG in the overview tab > latest transaction list?

It's the same size for every theme sooo... <link to PR philosophy here> 😄
Maybe we'll look at that later ;)

@UdjinM6
Copy link
Author

UdjinM6 commented May 13, 2016

I think we can merge this now and merge #777 as well. Is there anything else that needs to be fixed in this theme?

@akijuh
Copy link

akijuh commented May 13, 2016

One late note...

Send tab icon arrow point UP, but in transactions icon point RIGHT.
Receive tab icon arrow point DOWN, but in transactions icon point LEFT.

Shouldnt these icons need to be equal style?

Edit: I mean, point in the same direction.

@salmion
Copy link

salmion commented May 13, 2016

Well spotted. My logic on this was that incoming transaction point inward and outgoing point outward. trivial to make new ones if you all disagree.

@UdjinM6
Copy link
Author

UdjinM6 commented May 14, 2016

Shouldnt these icons need to be equal style?
Edit: I mean, point in the same direction.

I'd like to keep it the way it is because every theme uses this logic actually and I think it would be better to change them all at once in another PR if needed.

@eduffield222 eduffield222 merged commit 22661ad into dashpay:v0.12.1.x May 19, 2016
@akijuh
Copy link

akijuh commented May 20, 2016

Windows 7 64bit - Dash core v0.12.1.0-43cd805

Overview and Receive tab text is truncated when selected, because text is set bold.

lightthemetabs

@schinzelh
Copy link

schinzelh commented May 20, 2016

@akijuh good find! Applies to Windows 8.1 32bit as well - and Transactions and Masternodes are truncated too.

image

image

image

image

@UdjinM6 UdjinM6 mentioned this pull request May 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants