Use chainparams instead of standalone func for mn confirms #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduffield222
force-pushed
the
v0.12.1.x
branch
3 times, most recently
from
a311676
to
8501035
Compare
| @@ -496,7 +496,7 @@ bool CMasternodeBroadcast::CheckInputsAndAdd(int& nDos) | |||
| } | |||
|
|
|||
| // verify that sig time is legit in past | |||
| // should be at least not earlier than block when 1000 DASH tx got GetMasternodeConfirmationsRequired() | |||
| // should be at least not earlier than block when 1000 DASH tx got GetMasternodeConfirmationsRequired()() | |||
- Use function instead of chainparams directly
|
Windows build fails but it's a known issue, Linux and Mac OS builds compile fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve code quality by using chainparams for network specific mn confirm requirements