Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add guix sigs for thephez for 22.0.0-rc.1 #73

Merged
merged 2 commits into from
Nov 16, 2024
Merged

chore: add guix sigs for thephez for 22.0.0-rc.1 #73

merged 2 commits into from
Nov 16, 2024

Conversation

thephez
Copy link
Contributor

@thephez thephez commented Nov 14, 2024 •
edited
Loading

  • Unsigned
  • Signed

@UdjinM6 UdjinM6 mentioned this pull request Nov 15, 2024
Merged
5 tasks
@UdjinM6
Copy link
Contributor

UdjinM6 commented Nov 15, 2024

Hashes look good but there are too many of them, pls see dashpay/dash#6393

@PastaPastaPasta
Copy link
Member

It is fine to attest to more hashes no?

@UdjinM6
Copy link
Contributor

UdjinM6 commented Nov 15, 2024

It's impossible to verify extra hashes without building extra binaries too which kind of defeats the point of releasing binaries for some hosts only imo.

@PastaPastaPasta
Copy link
Member

That's okay imo; and, for this release at least, I built all of them too and they match. But I don't really want to clutter GitHub release with SOOO many artifacts.

@PastaPastaPasta
Copy link
Member

LGTM 1375d05

UdjinM6
UdjinM6 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 1375d05

UdjinM6
UdjinM6 approved these changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 11dc63a

@PastaPastaPasta PastaPastaPasta merged commit bc22909 into dashpay:master Nov 16, 2024
PastaPastaPasta added a commit to dashpay/dash that referenced this pull request Nov 26, 2024
@PastaPastaPasta
Merge #6393: docs: mention building for some HOSTs only in `release-p…
f98b0d5 
…rocess.md`

87c31ad Update doc/release-process.md (UdjinM6)
55d7463 docs: mention building for some HOSTs only in `release-process.md` (UdjinM6)

Pull request description:

  ## Issue being fixed or feature implemented
  dashpay/guix.sigs#73

  #6390 follow-up

  ## What was done?

  ## How Has This Been Tested?

  ## Breaking Changes

  ## Checklist:
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

Top commit has no ACKs.

Tree-SHA512: b4a2cadf5899a8aea6612b4ff9c0e9f9c530a9e2344eb090967fbcf9a2ab219aff02f11f86434e4082f84c401d578cf2d033b6838c94705f532beca4ab604986
knst pushed a commit to knst/dash that referenced this pull request Nov 26, 2024
@PastaPastaPasta @knst
Merge dashpay#6393: docs: mention building for some HOSTs only in `re…
5c28004 
…lease-process.md`

87c31ad Update doc/release-process.md (UdjinM6)
55d7463 docs: mention building for some HOSTs only in `release-process.md` (UdjinM6)

Pull request description:

  ## Issue being fixed or feature implemented
  dashpay/guix.sigs#73

  dashpay#6390 follow-up

  ## What was done?

  ## How Has This Been Tested?

  ## Breaking Changes

  ## Checklist:
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

Top commit has no ACKs.

Tree-SHA512: b4a2cadf5899a8aea6612b4ff9c0e9f9c530a9e2344eb090967fbcf9a2ab219aff02f11f86434e4082f84c401d578cf2d033b6838c94705f532beca4ab604986
knst pushed a commit to knst/dash that referenced this pull request Nov 26, 2024
@PastaPastaPasta @knst
Merge dashpay#6393: docs: mention building for some HOSTs only in `re…
3bbcd3d 
…lease-process.md`

87c31ad Update doc/release-process.md (UdjinM6)
55d7463 docs: mention building for some HOSTs only in `release-process.md` (UdjinM6)

Pull request description:

  ## Issue being fixed or feature implemented
  dashpay/guix.sigs#73

  dashpay#6390 follow-up

  ## What was done?

  ## How Has This Been Tested?

  ## Breaking Changes

  ## Checklist:
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

Top commit has no ACKs.

Tree-SHA512: b4a2cadf5899a8aea6612b4ff9c0e9f9c530a9e2344eb090967fbcf9a2ab219aff02f11f86434e4082f84c401d578cf2d033b6838c94705f532beca4ab604986
@thephez thephez deleted the thephez-22.0.0-rc.1 branch November 26, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thephez @UdjinM6 @PastaPastaPasta