Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update labels #7

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Update labels #7

merged 2 commits into from
Feb 1, 2022

Conversation

jacobtomlinson
Copy link
Member

This PR adds the labels proposed in dask/community#50 and will sync them with dask/dask and dask/distributed.

I will need to manually rename existing labels which are remaining, otherwise they will be deleted and recreated resulting in issues and PRs losing their labels.

So I'm just looking for a couple of approvals here to go ahead rather than a merge.

cc @mrocklin @jsignell @martindurant @jcrist @jakirkham @jrbourbeau

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jacobtomlinson!

@jakirkham
Copy link
Member

jakirkham commented Jun 4, 2020

Is it possible for users to select the issue type so as to label it correctly? Thinking of what we have in RAPIDS. Admittedly I am not sure whether that is something we want to do here. Just wondering 🙂

@jrbourbeau
Copy link
Member

When opening a new issue, one will have to pick between "Bug Report" or "Feature Request" (https://github.com/dask/dask/issues/new/choose), and the "Type:Bug" or "Type:Feature" label will be applied automatically. Is that what you're referring to, or do you mean other labels like "Area:Daraframe"?

@jakirkham
Copy link
Member

Yeah that's what I was thinking. This came up in issue ( dask/dask#4477 ) before. It might help cutdown on the maintenance effort. Though it does increase the effort for new users. Understand going either way here. So this is just a thought.

@jsignell
Copy link
Member

jsignell commented Jun 4, 2020

AFAICT only people with triage access can add labels, so it is not possible for most people.

@jakirkham
Copy link
Member

jakirkham commented Jun 4, 2020

Right so the idea would be to bake this into the template where labels can be added even if the user has no permissions.

Edit: Again this is just an idea. Not saying we should or should not do it.

@jacobtomlinson
Copy link
Member Author

This change means folks will be able to assign either the bug or enhancement labels by choosing the appropriate template. I think adding any further labels such as Area or Priority should be left down to the czar.

So I think this does satisfy your request @jakirkham.

Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with this as is :)

Base automatically changed from master to main February 5, 2021 19:50
@jsignell
Copy link
Member

@jacobtomlinson do you think we should merge this?

@jacobtomlinson
Copy link
Member Author

Sure. I'm a little apprehensive given the age of it. And I'm going to be out for the next couple of days.

If you're happy to watch out for any fallout then go for it, otherwise, maybe wait until next week?

@jsignell
Copy link
Member

yeah we can wait until next week :)

@jsignell
Copy link
Member

I think we shoudl just go ahead and merge this and we can always tweak it as we implement labeling

@jsignell jsignell merged commit 34349ec into dask:main Feb 1, 2022
@jsignell
Copy link
Member

jsignell commented Feb 1, 2022

Well that was anticlimactic :) it looks like this is depending on a branch that doesn't exist anymore, @jacobtomlinson do you by any chance remember what that was about?

@jsignell
Copy link
Member

jsignell commented Feb 1, 2022

aha! Got it micnncim/action-label-syncer#43 I'll open a PR to fix this up.

@jacobtomlinson jacobtomlinson deleted the apply-labels branch February 2, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants