-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update labels #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jacobtomlinson!
Is it possible for users to select the issue type so as to label it correctly? Thinking of what we have in RAPIDS. Admittedly I am not sure whether that is something we want to do here. Just wondering 🙂 |
When opening a new issue, one will have to pick between "Bug Report" or "Feature Request" (https://github.com/dask/dask/issues/new/choose), and the "Type:Bug" or "Type:Feature" label will be applied automatically. Is that what you're referring to, or do you mean other labels like "Area:Daraframe"? |
Yeah that's what I was thinking. This came up in issue ( dask/dask#4477 ) before. It might help cutdown on the maintenance effort. Though it does increase the effort for new users. Understand going either way here. So this is just a thought. |
AFAICT only people with triage access can add labels, so it is not possible for most people. |
Right so the idea would be to bake this into the template where labels can be added even if the user has no permissions. Edit: Again this is just an idea. Not saying we should or should not do it. |
This change means folks will be able to assign either the bug or enhancement labels by choosing the appropriate template. I think adding any further labels such as Area or Priority should be left down to the czar. So I think this does satisfy your request @jakirkham. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy with this as is :)
@jacobtomlinson do you think we should merge this? |
Sure. I'm a little apprehensive given the age of it. And I'm going to be out for the next couple of days. If you're happy to watch out for any fallout then go for it, otherwise, maybe wait until next week? |
yeah we can wait until next week :) |
I think we shoudl just go ahead and merge this and we can always tweak it as we implement labeling |
Well that was anticlimactic :) it looks like this is depending on a branch that doesn't exist anymore, @jacobtomlinson do you by any chance remember what that was about? |
aha! Got it micnncim/action-label-syncer#43 I'll open a PR to fix this up. |
This PR adds the labels proposed in dask/community#50 and will sync them with dask/dask and dask/distributed.
I will need to manually rename existing labels which are remaining, otherwise they will be deleted and recreated resulting in issues and PRs losing their labels.
So I'm just looking for a couple of approvals here to go ahead rather than a merge.
cc @mrocklin @jsignell @martindurant @jcrist @jakirkham @jrbourbeau