-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add issue labels #50
Comments
I don't think that we want a bot that comments on things, just a bot that tags an issue as unhandled. That way maintainers don't have to sift through issues to find things that should be pushed forward or cleared out. It serves the same purpose and needs-triage, just one week later. |
I just mentioned this in the maintenance meeting today, but wanted to leave a note here about github org level templates. I can't actually find the docs about it, but here is an example: https://github.com/actions/.github |
@jsignell I think this is what you were talking about. @mrocklin stale bot is configurable. It can add labels, comment or close at various intervals. You can pick and choose what functionality you want. The problem I always find with it is that you find yourself just removing the stale label continuously on low priority things that you just haven't managed to get to yet. Perhaps a conservative first stab at a stale bot config would just be to add the stale label to issues with the high priority label after 7 days of inactivity, which would prompt the Czars to push it again. |
Thanks @jacobtomlinson - I forgot that this already has a bunch of proposed content-area labels. I think in addition to the ones defined above are great although I'd propose adding I assume we'd be replacing old ones like:
Is something generic like |
I oppose this one, because we have a lot of issues around formats, particularly parquet |
So you are pro keeping IO @martindurant? |
Either one label for each or, yes, just Area:IO |
Ok that makes sense to me. |
Sorry for the delayed response. I'd like to propose we also have a "Type:Needs Info" label. It's useful for once an issue has been triaged, but more info is still required from the issue author (e.g. providing a minimal example) |
How should PRs that are not ready for review be handled? Periodically we have PRs that are not ready for review (and we don't want to bother others with), is there a way we can indicate that? |
Use a Draft Pull Request? |
We do that now. If we want to agree those are things that won't get triaged/labeled, that would be fine. |
I think if a PR is in draft we should just ignore it until the author puts it out of draft or specifically requests a review. |
I've updated my original post with the suggestions. I'll give this another 24 hours and then aplpy fo dask/dask and dask/distributed unless there are further suggestions. |
@jacobtomlinson I think Area:Bag and Area:Delayed would also be useful (and currently exist) |
This is an old issue, but I've been finding myself wanting a regression label and a feature request label. @jacobtomlinson how do you feel about merging dask/.github#7? |
Nervous given the age, it may be a little stale. But perhaps we should just go for it and watch for fallout? |
Yeah I just looked it over and it seems better than where we are currently at. |
Merged! |
I propose we add the following issue labels to all projects to help folks find things to work on and Czars to track high priority work. (see #49 (comment) for intial proposal).
I think we should ensure that every issue has one label from each category.
Based on suggestions these would be formatted with a colos, e.g
Type:Needs Triage
,Area:IO
,Priority:High
, etc.If anyone has suggestions please commend below and I'll edit this list accordingly.
Edit 3 Jun: Add suggested tags and note on formatting.
The text was updated successfully, but these errors were encountered: