Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue labels #50

Closed
jacobtomlinson opened this issue May 13, 2020 · 20 comments
Closed

Add issue labels #50

jacobtomlinson opened this issue May 13, 2020 · 20 comments
Assignees

Comments

@jacobtomlinson
Copy link
Member

jacobtomlinson commented May 13, 2020

I propose we add the following issue labels to all projects to help folks find things to work on and Czars to track high priority work. (see #49 (comment) for intial proposal).

I think we should ensure that every issue has one label from each category.

  • Type
    • Needs Triage
    • Needs Info
    • Bug (Something is broken)
    • Feature (Something is missing)
    • Hygiene (Code quality and project level things like adding issue templates)
    • Testing/CI
  • Area
    • Bag
    • Delayed
    • Core
    • Array
    • Daraframe
    • ML
    • Scheduler
    • Deployment
    • Diagnostics/Dashboard
    • Networking
    • IO
  • Skill level
    • Good first Dask ssue
    • Good second Dask issue
    • Expert needed
  • Priority
    • High
    • Medium
    • Low

Based on suggestions these would be formatted with a colos, e.g Type:Needs Triage, Area:IO, Priority:High, etc.

If anyone has suggestions please commend below and I'll edit this list accordingly.

Edit 3 Jun: Add suggested tags and note on formatting.

@jacobtomlinson
Copy link
Member Author

@mrocklin also suggested adding stale. I've used stale bot in other projects, which would be super fun to add to a project this size! But it can also be a bit overzealous.

@mrocklin
Copy link
Member

I don't think that we want a bot that comments on things, just a bot that tags an issue as unhandled. That way maintainers don't have to sift through issues to find things that should be pushed forward or cleared out. It serves the same purpose and needs-triage, just one week later.

@jacobtomlinson jacobtomlinson self-assigned this May 13, 2020
@jsignell
Copy link
Member

jsignell commented May 13, 2020

I just mentioned this in the maintenance meeting today, but wanted to leave a note here about github org level templates. I can't actually find the docs about it, but here is an example: https://github.com/actions/.github

@jacobtomlinson
Copy link
Member Author

@jsignell I think this is what you were talking about.

@mrocklin stale bot is configurable. It can add labels, comment or close at various intervals. You can pick and choose what functionality you want. The problem I always find with it is that you find yourself just removing the stale label continuously on low priority things that you just haven't managed to get to yet.

Perhaps a conservative first stab at a stale bot config would just be to add the stale label to issues with the high priority label after 7 days of inactivity, which would prompt the Czars to push it again.

@jsignell
Copy link
Member

jsignell commented Jun 2, 2020

Thanks @jacobtomlinson - I forgot that this already has a bunch of proposed content-area labels. I think in addition to the ones defined above are great although I'd propose adding Delayed, Bag, and Futures

I assume we'd be replacing old ones like:

  • dataframe -> Area:Dataframe
  • array -> Area:Array
  • io -> Area:FileSystems

Is something generic like core still a useful label? I would argue that it is because setting it indicates that the triager has thought about what label to apply and decided on one as opposed to the absence of an area tag being ambiguous.

@martindurant
Copy link
Member

io -> Area:FileSystems

I oppose this one, because we have a lot of issues around formats, particularly parquet

@jsignell
Copy link
Member

jsignell commented Jun 2, 2020

So you are pro keeping IO @martindurant?

@martindurant
Copy link
Member

Either one label for each or, yes, just Area:IO

@jsignell
Copy link
Member

jsignell commented Jun 2, 2020

Ok that makes sense to me.

@jrbourbeau
Copy link
Member

Sorry for the delayed response. I'd like to propose we also have a "Type:Needs Info" label. It's useful for once an issue has been triaged, but more info is still required from the issue author (e.g. providing a minimal example)

@jakirkham
Copy link
Member

How should PRs that are not ready for review be handled? Periodically we have PRs that are not ready for review (and we don't want to bother others with), is there a way we can indicate that?

@dhirschfeld
Copy link

is there a way we can indicate that?

Use a Draft Pull Request?

@jakirkham
Copy link
Member

We do that now. If we want to agree those are things that won't get triaged/labeled, that would be fine.

@jacobtomlinson
Copy link
Member Author

I think if a PR is in draft we should just ignore it until the author puts it out of draft or specifically requests a review.

@jacobtomlinson
Copy link
Member Author

I've updated my original post with the suggestions. I'll give this another 24 hours and then aplpy fo dask/dask and dask/distributed unless there are further suggestions.

@jsignell
Copy link
Member

jsignell commented Jun 3, 2020

@jacobtomlinson I think Area:Bag and Area:Delayed would also be useful (and currently exist)

@jsignell
Copy link
Member

This is an old issue, but I've been finding myself wanting a regression label and a feature request label. @jacobtomlinson how do you feel about merging dask/.github#7?

@jacobtomlinson
Copy link
Member Author

Nervous given the age, it may be a little stale. But perhaps we should just go for it and watch for fallout?

@jsignell
Copy link
Member

Yeah I just looked it over and it seems better than where we are currently at.

@jsignell
Copy link
Member

jsignell commented Feb 1, 2022

Merged!

@jsignell jsignell closed this as completed Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants