-
Notifications
You must be signed in to change notification settings - Fork 39
ENH: torch: allow negative indices in take and take_along_axis
#361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
take and take_along_axis
mdhaber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The matching test is exactly what I'd like to see. How can we see that torch passes the test with this change?
I'm kicking myself, but it looks like I didn't take note of where I experienced this, so I can't provide a test of where this came up in the wild, but the solution and tests LGTM.
Locally one incantation is (run from the source tree of the On CI, we'll need to land the array-api-tests fix first, and rerun the CI here to pick up the updated master branch of |
|
Oh, OK. Well the test change looked good, so I'll see when it runs here. |
|
Now that pytorch/pytorch#146211 is fixed in pytorch, we'll be able to undo the workaround of this PR for Also, we still need the workaround for |
|
data-apis/array-api-tests#397 (comment) : tests aiming to probe this pass locally, let's see if CI agrees. EDIT: and it does. Merging. |
fixes #360
A matching test update: data-apis/array-api-tests#397