From 8900ebf80d294733ae843c89ae43ed5dedc5bbb2 Mon Sep 17 00:00:00 2001 From: dlpzx <71252798+dlpzx@users.noreply.github.com> Date: Tue, 8 Aug 2023 09:30:06 +0200 Subject: [PATCH] resolve unnecessary dependency in git_release role (#623) ### Feature or Bugfix - Bugfix ### Detail - Remove small bug on the way we define the git release role - managed policies are attached after role creation - NOTE: The fix is already included in the `modularization-main` branch ### Relates - #617 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --- deploy/stacks/pipeline.py | 1 - 1 file changed, 1 deletion(-) diff --git a/deploy/stacks/pipeline.py b/deploy/stacks/pipeline.py index c9cdf9061..53dcf943a 100644 --- a/deploy/stacks/pipeline.py +++ b/deploy/stacks/pipeline.py @@ -331,7 +331,6 @@ def set_codebuild_iam_roles(self): iam.ServicePrincipal('codebuild.amazonaws.com'), iam.AccountPrincipal(self.account), ), - managed_policies=[self.baseline_codebuild_policy, self.git_release_policy, self.expanded_codebuild_policy] ) self.expanded_codebuild_policy.attach_to_role(self.git_project_role) self.baseline_codebuild_policy.attach_to_role(self.git_project_role)