Skip to content

Commit

Permalink
Fixes issue with existing cognito callbacks (#464)
Browse files Browse the repository at this point in the history
### Feature or Bugfix
- BugFix

### Detail
- In line
(https://github.com/awslabs/aws-dataall/blob/13a2fc082694600a0dacaa7e88d0d61ec950d753/deploy/configs/cognito_urls_config.py#L61)

It checks for example.com where instead the right callback to check is
```https://example.com``` and that's why it doesn't get replaced during
the configuration phase.

### Relates
- #454

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
  • Loading branch information
gmuslia authored May 17, 2023
1 parent 4ad8ce7 commit ee4f34c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions deploy/configs/cognito_urls_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ def setup_cognito(
f'https://{user_guide_link}/parseauth',
]
existing_callbacks = user_pool['UserPoolClient'].get('CallbackURLs', [])
if 'example.com' in existing_callbacks:
existing_callbacks.remove('example.com')
if 'https://example.com' in existing_callbacks:
existing_callbacks.remove('https://example.com')
updated_callbacks = existing_callbacks + list(
set(config_callbacks) - set(existing_callbacks)
)
Expand Down

0 comments on commit ee4f34c

Please sign in to comment.