Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validation mechanism and review validation in resolvers #1183

Open
dlpzx opened this issue Apr 17, 2024 · 0 comments
Open

Improve validation mechanism and review validation in resolvers #1183

dlpzx opened this issue Apr 17, 2024 · 0 comments

Comments

@dlpzx
Copy link
Contributor

dlpzx commented Apr 17, 2024

Is your idea related to a problem? Please describe.
There are 2 parts of the code that could be enhanced:

  1. resolvers is where we validate the api input and call the services, but in some cases this validation happens solely in the service
  2. validation in the services involves a lot of lines of code, there must be a better way to build RequestValidators

Describe the solution you'd like

  1. api input validation in resolvers
  2. simple validation where it is needed in services --> at the end services can be used by other services, so we need to ensure that the input is valid

P.S. Don't attach files. Please, prefer add code snippets directly in the message body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant