Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List and search for possible values when inviting a team within an environment #78

Closed
louishourcade opened this issue Jul 7, 2022 · 5 comments · Fixed by #158
Closed
Assignees
Labels
type: enhancement Feature enhacement
Milestone

Comments

@louishourcade
Copy link
Contributor

Is your idea related to a problem? Please describe.
In the current version, when you want to invite a team in an environment, data.all only lists the teams you are part of (as a data.all user). If I want to invite a team that my user is not part of, I need to provide it's name (free text). This is error prone as users can make a typo when providing the name, which will lead to problems down the road when trying to assume the role.

Describe the solution you'd like
When inviting teams, users should be able to list all "data.all" teams (drop-down list). There should also be a "search feature" to find the correct team to invite based on it's name.

@louishourcade louishourcade added the type: enhancement Feature enhacement label Jul 7, 2022
@dlpzx
Copy link
Contributor

dlpzx commented Jul 8, 2022

Completely agree, or at least check the validity of a group

@louishourcade louishourcade changed the title List and search for possible valeus when inviting a team within an environment List and search for possible values when inviting a team within an environment Jul 8, 2022
@dlpzx dlpzx added this to the v.1.1.0 milestone Jul 12, 2022
@dlpzx
Copy link
Contributor

dlpzx commented Sep 26, 2022

Implementation details

Backend:

  • Add a new Cognito handler in backend/aws/handlers with a list Groups method [https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/cognito-idp.html#CognitoIdentityProvider.Client.list_groups](boto3 call)
  • Add a new API of type Query in Groups object with its correspondent resolver that uses the Cognito handler

Frontend:

  • define a Groups object in src/api and add the definition of the API
  • modify the Environment view EnvironmentTeamInviteForm --> import the API + fetchGroups function with this API in useEffect + modify the textField to be a dropdown (Menu item) and map the values of fetchGroups with the values in this dropdown

@degoldner
Copy link
Contributor

@dlpzx we also though about giving the user more information about the users associated to a group for example which relates to this feature request. Aside the Cognito pool integration are you also considering querying the Azure AD?

@dlpzx
Copy link
Contributor

dlpzx commented Oct 17, 2022

Hi @degoldner, not yet. In the implementation we have created a new graphQL object called CognitoGroup. Right now it only includes the group name, but in the future it could also include other info such as "label" (for the case of non human readable names that come from azureAD) or even info about their creaton date...

@dlpzx
Copy link
Contributor

dlpzx commented Nov 4, 2022

Included in v1.2.0 release

@dlpzx dlpzx closed this as completed Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Feature enhacement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants