Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes issue with existing cognito callbacks #464

Merged

Conversation

gmuslia
Copy link
Contributor

@gmuslia gmuslia commented May 17, 2023

Feature or Bugfix

  • BugFix

Detail

It checks for example.com where instead the right callback to check is https://example.com and that's why it doesn't get replaced during the configuration phase.

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gmuslia gmuslia changed the title Fixes issue mentioned in https://github.com/awslabs/aws-dataall/issues/454 Fixes issue #454 May 17, 2023
@gmuslia gmuslia changed the title Fixes issue #454 Fixes issue with existing cognito callbacks May 17, 2023
Copy link
Contributor

@dlpzx dlpzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dlpzx dlpzx merged commit ee4f34c into data-dot-all:main May 17, 2023
@dlpzx dlpzx changed the title Fixes issue with existing cognito callbacks fix: Fixes issue with existing cognito callbacks May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants