Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add npm packages check and rename other github actions #536

Closed
wants to merge 17 commits into from

Conversation

dlpzx
Copy link
Contributor

@dlpzx dlpzx commented Jun 27, 2023

Feature or Bugfix

  • Feature

Detail

Added npm audit chekc and eslint checks
Reorganised and renamed workflows to be more specific (Safety, lint)

Upgrade package installation in dockerfiles to use yarn -> tested in AWS deployment
Remove safety as it is licensed for non-commercial use only (https://pypi.org/project/safety/)
Add semgrep instead for both frontend and backend code. Still in progress!

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlpzx dlpzx marked this pull request as ready for review June 28, 2023 13:45
@dlpzx dlpzx requested a review from jaidisido June 28, 2023 13:45
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@dlpzx
Copy link
Contributor Author

dlpzx commented Sep 12, 2023

Close as it is already done in #726

@dlpzx dlpzx closed this Sep 12, 2023
@dlpzx dlpzx deleted the feature/github-security-checks-frontend branch September 13, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant