Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add npmaudit and semgrep in github workflows. Fix dependabot on merge package #751

Merged
merged 5 commits into from
Sep 13, 2023

Conversation

dlpzx
Copy link
Contributor

@dlpzx dlpzx commented Sep 13, 2023

Feature or Bugfix

  • Feature
  • Bugfix

Detail

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

"nth-check": "^2.0.1",
"@adobe/css-tools": "4.3.1"
"@adobe/css-tools": "4.3.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we wanted to remove this from package.json after generating the integrity sha-id in yarn.lock

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to leave it to ensure that if we generate another yarn.lock it forces the non-vulnerable version of the package.

@dlpzx
Copy link
Contributor Author

dlpzx commented Sep 13, 2023

Tested in AWS.

@dlpzx dlpzx merged commit 14ac196 into main Sep 13, 2023
7 checks passed
@dlpzx dlpzx deleted the feature/add-npmaudit-semgrep branch November 8, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants